Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical regridding - fix stagger mismatch #3188

Closed
wants to merge 17 commits into from
Closed

Vertical regridding - fix stagger mismatch #3188

wants to merge 17 commits into from

Conversation

pchakraborty
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@pchakraborty
FixedLevelsVerticalGrid - replaced MAPL_GeomGet_ with assign_fptr_con…
dbf8bd2 
…densed_array
@pchakraborty
Merge remote-tracking branch 'origin/release/MAPL-v3' into feature/pc…
9d21354 
…hakrab/vertical-regridding
@pchakraborty
Working
d3c0385
@pchakraborty
Working
c6f436c
@pchakraborty
Specify short names corresponding to standard_name
a2cc0b5
@pchakraborty
Merge remote-tracking branch 'origin/release/MAPL-v3' into feature/pc…
5514294 
…hakrab/vertical-regridding
@pchakraborty
Replaced the string array variants(2) with two variables
25b5756
@pchakraborty
Updated Scenarios test vertical_regridding_2
a5424b7
@pchakraborty
Test_ModelVerticalGrid - updated to use the new ModelVerticalGrid int…
8208aa6 
…erface
@pchakraborty
Removed unused parameters
234ee55
@pchakraborty
Enabling vertical regridding between variables with different vertica…
dece8a4 
…l stagger
@pchakraborty
Added check for value etc. in vertical_regridding scenarios test
99613a3
@pchakraborty
Vertical regridding between variables with different vertical stagger
810ebb4
@pchakraborty
ModelVerticalLevel - removed unused modules
38f2d09
@pchakraborty
Removed unnecessary returns
32b9fa3
@pchakraborty
Enforcing keyword argument in ModelVerticalGrid::add_short_name
fe9fb8b 
Plus, renamed add_short_names -> add_short_name
@pchakraborty
Merge branch 'feature/pchakrab/vertical-regridding' into feature/pcha…
a0cdfee 
…krab/vertical-regridding-fix-stagger-mismatch
@pchakraborty pchakraborty self-assigned this Nov 19, 2024
@pchakraborty pchakraborty added 🪲 Bug Something isn't working 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Nov 19, 2024
@pchakraborty
Copy link
Contributor Author

Closing in favor of #3190

@pchakraborty pchakraborty deleted the feature/pchakrab/vertical-regridding-fix-stagger-mismatch branch November 20, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@818Nawaf 818Nawaf 818Nawaf approved these changes

Assignees

@pchakraborty pchakraborty

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bug Something isn't working Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pchakraborty @818Nawaf