Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select short name of variable defining ModelVerticalGrid #3182

Merged
merged 13 commits into from
Nov 20, 2024
Merged

Select short name of variable defining ModelVerticalGrid #3182

merged 13 commits into from
Nov 20, 2024

Conversation

pchakraborty
Copy link
Contributor

@pchakraborty pchakraborty commented Nov 15, 2024 •
edited
Loading

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

  • A Model VerticalGrid is now instantiated with standard_name, units and num_levels. The method add_short_name is used to specify variable short names corresponding to edge and center vertical staggerings, which is selected at runtime using the method get_short_name.
  • Updated ComponentSpecParse::parse_geometry_spec to use the new interface.
  • Updated Test_ModelVerticalGrid.pf to use the new interface.
  • Updated vertical regridding tests to specify standard_name instead of short_name for Model VerticalGrids.
  • Cleanup of FixedLevels VerticalGrid - we didn't need MAPL_BaseMod::MAPL_GridGet after all.

Related Issue

@pchakraborty pchakraborty self-assigned this Nov 15, 2024
@pchakraborty pchakraborty added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Nov 15, 2024
@pchakraborty pchakraborty marked this pull request as ready for review November 15, 2024 12:55
@pchakraborty pchakraborty requested a review from a team as a code owner November 15, 2024 12:55
@pchakraborty pchakraborty mentioned this pull request Nov 15, 2024
Closed
tclune
tclune requested changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes requested. See inline comments.

tclune
tclune approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pchakraborty pchakraborty merged commit 246e402 into release/MAPL-v3 Nov 20, 2024
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@818Nawaf 818Nawaf 818Nawaf approved these changes

@tclune tclune tclune approved these changes

Assignees

@pchakraborty pchakraborty

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchakraborty @tclune @818Nawaf