Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tclune/reduce compiler warnings #2324

Merged
merged 15 commits into from
Sep 5, 2023
Merged

Feature/tclune/reduce compiler warnings #2324

merged 15 commits into from
Sep 5, 2023

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Sep 1, 2023

Description

This PR reduces the number of annoying messages emitted by the compiler. By keeping the code clean, we expect that we will notice more important warning messages more readily.

Related Issue

Motivation and Context

How Has This Been Tested?

Compiles with NAG on M2 mac.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring labels Sep 1, 2023
@tclune tclune requested review from a team as code owners September 1, 2023 20:01
mathomp4
mathomp4 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with GEOSgcm and it was zero-diff. As it better be.

@mathomp4 mathomp4 merged commit 13a11e9 into develop Sep 5, 2023
8 checks passed
@mathomp4 mathomp4 deleted the feature/tclune/reduce-compiler-warnings branch September 5, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclune @mathomp4