Skip to content

Commit

Permalink
fix: Set methods with @Transactional to public (#6)
Browse files Browse the repository at this point in the history
  • Loading branch information
nusuy committed Dec 14, 2023
1 parent 96c1615 commit 33d7be8
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public ResponseEntity<Object> findAllMembers(FilterOptionsRequestDto filterOptio
}

@Transactional
private boolean isMemberMatch(MemberResponseDto filteredMembers, FilterOptionsRequestDto filterOptionsRequestDto) {
public boolean isMemberMatch(MemberResponseDto filteredMembers, FilterOptionsRequestDto filterOptionsRequestDto) {
// 셋다 true 여야 return 해주는 로직
boolean partMatch;
boolean levelMatch;
Expand Down Expand Up @@ -115,7 +115,7 @@ private boolean isMemberMatch(MemberResponseDto filteredMembers, FilterOptionsRe


@Transactional
private MemberResponseDto createMemberResponseDto(Member member, FilterOptionsRequestDto filterOptionsRequestDto) {
public MemberResponseDto createMemberResponseDto(Member member, FilterOptionsRequestDto filterOptionsRequestDto) {
// 북마크 db 에서 해당 멤버가 존재하는지 확인, bookmark 값 정하기
boolean bookmark = bookmarkRepository.existsByTargetMemberId(member.getId());
// generationResponseDtoList 만들기 위해 함수 호출
Expand All @@ -129,7 +129,7 @@ private MemberResponseDto createMemberResponseDto(Member member, FilterOptionsRe
}

@Transactional
private List<GenerationResponseDto> createGenerationResponseDtoList(Member member, FilterOptionsRequestDto filterOptionsRequestDto) {
public List<GenerationResponseDto> createGenerationResponseDtoList(Member member, FilterOptionsRequestDto filterOptionsRequestDto) {
// 해당 멤버 Generation
List<Generation> generationList = generationRepository.findByMember(member);
return generationList.stream()
Expand All @@ -146,7 +146,7 @@ private List<GenerationResponseDto> createGenerationResponseDtoList(Member membe
}

@Transactional
private List<ProjectResponseDto> createProjectResponseDtoList(Member member, Generation generation, FilterOptionsRequestDto filterOptionsRequestDto) {
public List<ProjectResponseDto> createProjectResponseDtoList(Member member, Generation generation, FilterOptionsRequestDto filterOptionsRequestDto) {
List<Project> projects = projectRepository.findByMemberAndGeneration(member, generation);

Set<String> existingParts = new HashSet<>();
Expand Down

0 comments on commit 33d7be8

Please sign in to comment.