ESLint 수정 및 업데이트 (#162)

* chore: eslint 업데이트 및 버전 업데이트

* Fix: EsLint 수정

* Env: 배포 전 모든 브랜치 별로 Lint 및 Test하도록 Ci.yml 추가

* Fix: PR시에만 Lint 가능하도록 Action 추가

* Env: 최대 Lint Warning개수 50개 제한

* chore: pnpm eslint 및 prettier 수정

* Chore: EsLint 수정

.eslintrc.json

@@ -50,18 +50,28 @@
       "error",
       {
         "endOfLine": "auto",
-        "singleQuote": true,
-        "importOrder": "off"
+        "singleQuote": true
       }
     ],
     "react/react-in-jsx-scope": "off",
     "import/no-unresolved": "off",
     "@typescript-eslint/no-unused-vars": "warn",
-    "no-console": "warn",
+    "no-console": "off",
     "arrow-body-style": "off",
     "prefer-arrow-callback": "off",
     "max-len": "off",
     "no-mixed-operators": "off",
-    "no-multiple-empty-lines": "off"
+    "no-multiple-empty-lines": "off",
+    "import/order": [
+      "error",
+      {
+        "groups": [
+          ["builtin", "external"],
+          "internal",
+          ["parent", "sibling", "index"]
+        ],
+        "newlines-between": "always"
+      }
+    ]
   }
 }

.github/workflows/ci.yml

@@ -1,9 +1,9 @@
-name: Test
+name: Test and Lint
 
 on:
     pull_request:
         branches:
-            - main
+            - '**'
     workflow_dispatch:
 
 jobs:
@@ -21,6 +21,9 @@ jobs:
             - name: Install Dependencies
               run: pnpm install 
 
+            - name: Run Lint
+              run: pnpm lint --max-warnings 50
+
             - name: Run Test
-              run: pnpm run test
+              run: pnpm test
 

.prettierrc.json

@@ -18,28 +18,6 @@
   "useTabs": false,
   "vueIndentScriptAndStyle": false,
 
-  "plugins": ["@trivago/prettier-plugin-sort-imports"],
-  "importOrder": [
-    "^react",
-
-    "<THIRD_PARTY_MODULES>",
-
-    "^(@gdg/components)(.*)$",
-    "^(@gdg/pages)(.*)$",
-    "^(@gdg/hooks)(.*)$",
-    "^(@gdg/assets)(.*)$",
-
-    "^(@gdg/constants)(.*)$",
-    "^(@gdg/utils)(.*)$",
-    "^(@gdg/apis)(.*)$",
-    "^(@gdg/common)(.*)$",
-    "^(@gdg/config)(.*)$",
-    "^(@gdg/store)(.*)$",
-
-    "^(@gdg/styles)(.*)$",
-
-    "^(.*)/(.*)$"
-  ],
   "importOrderSeparation": true,
   "importOrderSortSpecifiers": false
 }

package.json

@@ -61,7 +61,6 @@
     "@prerenderer/renderer-puppeteer": "^1.2.4",
     "@prerenderer/rollup-plugin": "^0.3.12",
     "@testing-library/jest-dom": "^6.6.3",
-    "@trivago/prettier-plugin-sort-imports": "^4.3.0",
     "@types/jest": "^29.5.14",
     "@types/node": "^20.17.6",
     "@types/prismjs": "^1.26.5",
@@ -83,7 +82,7 @@
     "eslint-plugin-react-refresh": "^0.4.14",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",
-    "prettier": "^2.8.8",
+    "prettier": "^3.3.3",
     "puppeteer": "^23.8.0",
     "ts-node": "^10.9.2",
     "typescript": "^5.6.3",