965 schemas for inreach cmd populate schema folder #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 14, 2023 17:26
This was
linked to
issues
Mar 16, 2023
…lt user input for schema create as 'N'
alexgao1
previously approved these changes
Mar 16, 2023
billingb
reviewed
Mar 16, 2023
| // Write JSON to file | ||
| File file = new File(schemaDir, "definition.json"); | ||
| try { | ||
| FileOutputStream fos = new FileOutputStream(file); |
There was a problem hiding this comment.
Don't need the flush statements (close flushes, and these aren't buffered writers anyway).
Can we switch this all over the try-with-resource pattern? That was introduced to make the closing of streams better/cleaner and handle exceptions better. This stack overflow shows multiple stream try-with-resource https://stackoverflow.com/questions/41248572/sonar-how-to-use-try-with-resources-to-close-fileoutputstream
There was a problem hiding this comment.
…hemas-for-inreach-cmd-populate-schema-folder
billingb
approved these changes
Mar 17, 2023
kunwarj
deleted the
965-schemas-for-inreach-cmd-populate-schema-folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix helps to pass --add-schema flag to create schema for inReach forms with schemas-for-inreach command.
If the flag is not passed it asks the user if they want to create a schema or not. create schema if users answers "yes", else just print out the JSON definition.