fix an invalid editor window size on second startup at the hidpi display #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably was broken in the 811a134 commit for the FyroxEngine#453 issue, but issue still not fixed. The window_size field is used as the PhysicalSize in all other cases.
Vlad2001MFS
force-pushed
the
fix_453_invalid_editor_window_size_hidpi
branch
from
26b84b5 to
3e066c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably was broken in the
811a13426ddb808e778c6ac436671eef87aab9afcommit for the #453 issue, but issue still not fixed.The window_size field is used as the
PhysicalSizein all other cases.Editor start with a size greater than a display size if it takes the window size from the
settings.ron.Maybe the problem of the #453 what the
logical_sizeis used for theuser_interfacesactions when in other places in code thePhysicalSizewas passed to render related code? What if some of that places also needs in theLogicalSizeinstead of thePhysicalSize?Host PC info:
OS: Windows 11 23H2
Display: 1920x1080 scaling 150%, 2560x1440 scaling 150%