Address missing GenerateAnswer in trajectories, no answers after Complete tools, and better history
#726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mskarlin
commented
Nov 27, 2024
mskarlin
commented
- Moved the tool_history into session -- so it can be externally accessed for tests + debugging.
- Added a history check for gen_answer in runner, it uses the history to ensure it's there.
- Added a sentinel into complete tool, this will allow trajectories where this tool is used outside of the runner to have something populated in the answer.
…unner; add sentinel into complete tool
mskarlin
requested review from
whitead,
jamesbraza,
maykcaldas and
nadolskit
dosubot
bot
added
size:M
mskarlin
commented
Nov 27, 2024
mskarlin
commented
Nov 27, 2024
jamesbraza
reviewed
Nov 27, 2024
jamesbraza
reviewed
Nov 27, 2024
jamesbraza
reviewed
Nov 27, 2024
jamesbraza
approved these changes
Nov 27, 2024
| @@ -357,6 +354,8 @@ class Complete(NamedTool): | |||
| r" \| " + EnvironmentState.STATUS_SEARCH_REGEX_PATTERN | |||
| ) | |||
|
|
|||
| NO_ANSWER_PHRASE: ClassVar[str] = "No answer generated." | |||
There was a problem hiding this comment.
Should we move this to PQASession since that's where it will be used most likely? Imo housing this in the Complete tool makes it less accessible (since Complete tool is sort of an agent implementation detail)
|
Note I'm merging w.o CI passing because we seem to still be getting 502s from openAI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.