Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support to BatchAPIs to gather evidence #687
base: main
Are you sure you want to change the base?
Implement support to BatchAPIs to gather evidence #687
Changes from 16 commits
2385dce
8a21055
5f59681
6f7bbb5
e8dc0d0
899de43
16c3988
d10a268
0fe9aa1
a9ad540
9a0a6c4
723650d
660bfa0
977a025
ee351f2
293658a
1ad1c7c
af32005
63e4b39
f61e629
d7dbd72
7c37f6d
de18907
3e72bd4
7c7f4b8
6c8f186
0e43a7c
17c26eb
c258306
4b8e1c3
8b5c1fa
ab40b54
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did we cut the
r is not None
filter here? I would think that the results fromgather_with_concurrency
could still beNone
on failure, but maybe I'm wrongThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets the
Context
s fromgather_with_concurrency
orgather_with_batch
. And both always return list of tuples with (Context
,LLMResult
). What can happen is to have an empty text inContext.text
, but it seems to me that r is always an instance ofContext
.Also, I didn't see any case of
map_fxn_summary
returningNone
while studying the code, and mypy also complains thatr is None
is always a True statement.Maybe that's an edge case that I didn't see?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we correctly type hinted
gather_with_concurrency
then this would be resolved. @maykcaldas can you adjust it to be this?