Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add missing changes and links to Changelog #3655

Merged
merged 11 commits into from
Oct 23, 2024
Merged

[docs] Add missing changes and links to Changelog #3655

merged 11 commits into from
Oct 23, 2024

Conversation

Hundrec
Copy link
Contributor

@Hundrec Hundrec commented Oct 12, 2024 •
edited
Loading

(fixes #3676)
Oh whoops, was doing this at the same time as Eric

I've made a bunch of changes to the changelog that I think are necessary, so I'll be adding a commit to resolve merge conflicts with Eric's commit

All resolved!

Changes

  • [NEW] Add and polish changes for 0.5.3
  • Add a few changes that are missing due to closed PRs
  • Add PR links for new contributors in 0.5.2
  • Add new contributors sections for 0.5.1, 0.5.0, 0.4.1, 0.4.0, and 0.3.3
  • Add links to pull requests for all changes that came from a PR for all versions back to 0.3.3
  • Tweak the spellings of some contributors' names to match their usernames on GitHub
  • Various spelling and grammar fixes after 0.3.0
  • Remove duplicate entries
  • Fix a broken link in 0.4.1

And most of all...

  • Change the 'h' in "2hot" to lowercase (and fixed M.I.L.F and DadBattle)

@github-actions github-actions bot added medium A medium pull request with 100 or fewer changes documentation Issue/PR modifies documentation or README files labels Oct 12, 2024
@github-actions github-actions bot added large A large pull request with more than 100 changes and removed medium A medium pull request with 100 or fewer changes labels Oct 12, 2024
@Hundrec Hundrec changed the title [docs] Rewrite 0.5.2 Changelog (and add a ton of links) [docs] Add missing changes and links to Changelog Oct 12, 2024
@Hundrec Hundrec mentioned this pull request Oct 13, 2024
Closed
2 tasks
JVNpixels
JVNpixels approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@JVNpixels JVNpixels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, perfect!

@EliteMasterEric EliteMasterEric self-assigned this Oct 15, 2024
@EliteMasterEric EliteMasterEric added type: documentation Is related to improvements or additions to documentation. status: reviewing internally This PR is under internal review and quality assurance testing labels Oct 15, 2024
@EliteMasterEric
Copy link
Member

This is great! I would like to see if this can get rebase/squashed to be compatible with the current main branch.

@JVNpixels
Copy link
Contributor

whoops, forgot to add a period, thank you for adding it Hundrec!

@EliteMasterEric EliteMasterEric added this to the 0.5.2 milestone Oct 16, 2024
@Hundrec
Copy link
Contributor Author

Hundrec commented Oct 23, 2024

I've included the latest changes from 0.5.3 and fixed up a few things:

  • Removed a duplicate entry
  • Reordered an enum fix for better readability
  • Finished the final sentence (with what I think you meant to write)

I want to squash this into one commit, but I'm not sure how to. Can you guys do it?

@EliteMasterEric
Copy link
Member

Let's see if this works

@EliteMasterEric EliteMasterEric merged commit c0b15ec into FunkinCrew:main Oct 23, 2024
2 checks passed
@Keoiki
Copy link
Contributor

Keoiki commented Oct 23, 2024

Well now the 0.5.3 changelog is inconsistent between Main and Develop branches since the final entry is completely different

@Hundrec
Copy link
Contributor Author

Hundrec commented Oct 23, 2024

Whoops! Didn't realize Eric finished his sentence in develop.
I'll let Eric handle the conflict.

lemz1 pushed a commit to lemz1/Funkin that referenced this pull request Oct 30, 2024
@Hundrec @lemz1
[docs] Add missing changes and links to Changelog (FunkinCrew#3655)
ef1af0b 
* changelog sweep

* Resolve a few conflicts

* Resolve more conflicts

* DadBattle

* Re-add @ianharrigan

* Add links to 0.5.0

* Add links and contributors to 0.4.1 and 0.4.0

* Add links to 0.3.3 and finishing touches

* Add and polish 0.5.3 changes

* Make spacing consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JVNpixels JVNpixels JVNpixels approved these changes

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

@ninjamuffin99 ninjamuffin99 Awaiting requested review from ninjamuffin99

Assignees

@EliteMasterEric EliteMasterEric

Labels
documentation Issue/PR modifies documentation or README files large A large pull request with more than 100 changes status: reviewing internally This PR is under internal review and quality assurance testing type: documentation Is related to improvements or additions to documentation.
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.

Enhancement: Changelog Fixing
4 participants
@Hundrec @EliteMasterEric @JVNpixels @Keoiki