Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forc.toml metadata support #6728

Merged
merged 14 commits into from
Nov 19, 2024
Merged

Forc.toml metadata support #6728

merged 14 commits into from
Nov 19, 2024

Conversation

zees-dev
Copy link
Contributor

@zees-dev zees-dev commented Nov 17, 2024

@zees-dev zees-dev requested a review from a team as a code owner November 17, 2024 22:54
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #6728 will not alter performance

Comparing feat/forc-toml-metadata-support (0452cdc) with master (9741809)

Summary

✅ 22 untouched benchmarks

Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit but otherwise LGTM 💯

forc-pkg/src/manifest/mod.rs Show resolved Hide resolved
@kayagokalp kayagokalp added forc-pkg Everything related to the `forc-pkg` crate. enhancement New feature or request labels Nov 18, 2024
@JoshuaBatty
Copy link
Member

Nice one. It would be nice to add some documentation about this feature so developers of plugins are aware that this is now possible. I imagine you could put something together using the motivations already written in the RFC and #2180.

Adding it to the manifest reference probably makes the most sense https://docs.fuel.network/docs/forc/manifest_reference/

alfiedotwtf
alfiedotwtf previously approved these changes Nov 18, 2024
sdankel
sdankel previously approved these changes Nov 18, 2024
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to approve once CI is passing

Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this.

@zees-dev zees-dev merged commit 519f208 into master Nov 19, 2024
45 checks passed
@zees-dev zees-dev deleted the feat/forc-toml-metadata-support branch November 19, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request forc-pkg Everything related to the `forc-pkg` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting external / 3rd-party plugin configuration in Forc.toml with a metadata table
5 participants