-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forc.toml
metadata support
#6728
Conversation
CodSpeed Performance ReportMerging #6728 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a nit but otherwise LGTM 💯
Nice one. It would be nice to add some documentation about this feature so developers of plugins are aware that this is now possible. I imagine you could put something together using the motivations already written in the RFC and #2180. Adding it to the manifest reference probably makes the most sense https://docs.fuel.network/docs/forc/manifest_reference/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, happy to approve once CI is passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this.
Description
Adds support for
metadata
as[project.metadata]
or[workspace.metadata]
inForc.toml
of valuetoml::Value
Forc.toml
with ametadata
table #2180Linked examples of usage
forc-index
Forc.toml
metadata
example-forc-plugins#1