Merge pull request #283 from fcoronelmakingsense/reports-unic-visits

add: unique visits in reports

src/components/Reports/ReportsPageRanking/ReportsPageRanking.js

@@ -95,7 +95,7 @@ class ReportsPageRanking extends React.Component {
                     {item.name}
                   </a>
                   <p className="text-ranking">
-                    <strong>{item.totalVisits}</strong>{' '}
+                    <strong>{item.totalVisitors}</strong>{' '}
                     <FormattedMessage id="reports_pageranking.total_visits" />
                   </p>
                 </div>

src/i18n/en.js

@@ -155,8 +155,7 @@ export default {
   },
   reports_pageranking: {
     top_pages: `Most visited pages`,
-    top_pages_sub_head: `Sessions are the total number of registered visits during the period. If a user entered several times, all of them will be counted.`,
-    total_visits: `Sessions`,
+    total_visits: `Unique visitors`,
   },
   reports_title: `Doppler | Reports`,
   signup: {

src/i18n/es.js

@@ -155,8 +155,7 @@ export default {
   },
   reports_pageranking: {
     top_pages: `Páginas más visitadas`,
-    top_pages_sub_head: `Las Sesiones comprenden el número total de visitas registradas durante el periodo. Si un usuario ingresó varias veces, se contabilizarán todas.`,
-    total_visits: `Sesiones`,
+    total_visits: `Visitantes únicos`,
   },
   reports_title: `Doppler | Reportes`,
   signup: {

src/services/datahub-client.doubles.ts

@@ -23,23 +23,23 @@ const fakeData = [
 const fakePagesData = [
   {
     name: '/email-marketing',
-    totalVisits: 10122,
+    totalVisitors: 10122,
   },
   {
     name: '/precios',
-    totalVisits: 9000,
+    totalVisitors: 9000,
   },
   {
     name: '/login',
-    totalVisits: 5001,
+    totalVisitors: 5001,
   },
   {
     name: '/productos',
-    totalVisits: 3800,
+    totalVisitors: 3800,
   },
   {
     name: '/servicios',
-    totalVisits: 1023,
+    totalVisitors: 1023,
   },
 ];
 
@@ -72,12 +72,12 @@ export class HardcodedDatahubClient implements DatahubClient {
   }: {
     domainName: number;
     dateFrom: Date;
-  }): Promise<{ name: string; totalVisits: number; url: string }[]> {
+  }): Promise<{ name: string; totalVisitors: number; url: string }[]> {
     console.log('getPagesRankingByPeriod', { domainName, dateFrom });
     await timeout(1500);
     return fakePagesData.map((x) => ({
       name: x.name,
-      totalVisits: x.totalVisits,
+      totalVisitors: x.totalVisitors,
       url: `http://${domainName}${x.name}`,
     }));
   }

src/services/datahub-client.ts

@@ -19,7 +19,7 @@ export interface DatahubClient {
   getPagesRankingByPeriod(query: {
     domainName: number;
     dateFrom: Date;
-  }): Promise<{ name: string; totalVisits: number; url: string }[]>;
+  }): Promise<{ name: string; totalVisitors: number; url: string }[]>;
 }
 
 export class HttpDatahubClient implements DatahubClient {
@@ -101,21 +101,21 @@ export class HttpDatahubClient implements DatahubClient {
   }: {
     domainName: number;
     dateFrom: Date;
-  }): Promise<{ name: string; totalVisits: number; url: string }[]> {
-    const response = await this.customerGet<{ items: { page: string; count: number }[] }>(
-      `domains/${domainName}/events/summarized-by-page`,
-      {
-        startDate: dateFrom.toISOString(),
-      },
-    );
+  }): Promise<{ name: string; totalVisitors: number; url: string }[]> {
+    const response = await this.customerGet<{
+      items: { page: string; visitorsQuantity: number }[];
+    }>(`domains/${domainName}/events/summarized-by-page`, {
+      startDate: dateFrom.toISOString(),
+      sortBy: 'visitors',
+    });
 
     // By the moment we are hard-coding it because DataHub does not have this
     // information. I am looking you Leo :P
     const urlSchema = 'http://';
 
     return response.data.items.map((x) => ({
       name: x.page,
-      totalVisits: x.count,
+      totalVisitors: x.visitorsQuantity,
       url: `${urlSchema}${domainName}${x.page}`,
     }));
   }