Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: array deserialization #26

Merged
merged 1 commit into from
Feb 4, 2024
Merged

fix: array deserialization #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/js-client/src/core/remote-storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class RemoteStorage {
}
const data = await response.text()
// Check if valid JSON
if (!data.startsWith('{')) {
if (!data.startsWith('{') && !data.startsWith('[')) {
if (data === 'true') {
return true as unknown as T
}
Expand Down
7 changes: 7 additions & 0 deletions packages/js-client/test/remote-storage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,13 @@ describe('global storage', () => {
expect(value).toEqual('value')
})

it('should be able to set and get an array', async () => {
const remoteStorage = new RemoteStorage(getConfig())
await remoteStorage.setItem('key', ['foo', 'bar'])
const value = await remoteStorage.getItem<string[]>('key')
expect(value).toEqual(['foo', 'bar'])
})

it('should be able to set and get an object', async () => {
const remoteStorage = new RemoteStorage(getConfig())
await remoteStorage.setItem('key', { foo: 'bar' })
Expand Down
Loading