Small improvements #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e past and is now kept to ensure same behaviour)
HellMar
requested changes
Oct 10, 2019
Comment on lines
-96
to
97
| "5gl-inet": {id: "gl-inet", name: "GL-Inet"}, | ||
| "5gl-inet": {id: "gl", name: "GL Innovations"}, |
There was a problem hiding this comment.
Das geht so nicht. Das sind 2 Unterschiedliche Modelle die einfach nur den gleichen Key nutzen. Richtig wäre gewesen den Key an zu passen.
There was a problem hiding this comment.
stimmt da war ich zu schnell.
| "13wd-ny-net": {id: "wd-ny-net", name: "WD My Net"}, | ||
| "13wd-ny-net": {id: "raspberrypi", name: "Raspberry Pi"}, |
There was a problem hiding this comment.
Das geht so nicht. Das sind 2 Unterschiedliche Modelle die einfach nur den gleichen Key nutzen. Richtig wäre gewesen den Key an zu passen.
There was a problem hiding this comment.
stimmt da war ich zu schnell.
|
zu gunsten eines neuen und sauberen PRs (#27) wird diese PR hier geschlossen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Einpaar Einträge waren "doppelt" (identischer key). Der Wert des zuletzt definierten key setzte sich immer durch. Die unnötige "Dopplung" habe ich entfernt und das statement mit Semikolon (welches fehlte) abgeschlossen.
Bitte vor dem merge einmal testen, ob das Verhalten nach der Änderung immer noch korrekt ist.