WIP: Make/asyncio just to easily see diff DO NOT MERGE #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 28, 2018 17:58
…es which is more reliable and has more information
# Conflicts: # examples/client-minimal-auth.py # examples/client-minimal.py # opcua/client/client.py # opcua/client/ua_client.py # opcua/common/copy_node.py # opcua/common/events.py # opcua/common/instantiate.py # opcua/common/node.py # opcua/common/ua_utils.py # opcua/server/address_space.py # opcua/server/event_generator.py # opcua/server/internal_server.py # opcua/server/server.py # opcua/server/standard_address_space/standard_address_space_part3.py # opcua/server/standard_address_space/standard_address_space_part4.py # opcua/server/standard_address_space/standard_address_space_part5.py # opcua/server/standard_address_space/standard_address_space_part8.py # opcua/server/standard_address_space/standard_address_space_part9.py # opcua/server/uaprocessor.py # opcua/ua/ua_binary.py # opcua/ua/uaprotocol_auto.py # opcua/ua/uatypes.py # schemas/AttributeIds.csv # schemas/NodeIds.csv # schemas/Opc.Ua.Adi.NodeSet2.xml # schemas/Opc.Ua.Adi.Types.bsd # schemas/Opc.Ua.Adi.Types.xsd # schemas/Opc.Ua.Endpoints.wsdl # schemas/Opc.Ua.NodeSet2.Part10.xml # schemas/Opc.Ua.NodeSet2.Part11.xml # schemas/Opc.Ua.NodeSet2.Part13.xml # schemas/Opc.Ua.NodeSet2.Part3.xml # schemas/Opc.Ua.NodeSet2.Part4.xml # schemas/Opc.Ua.NodeSet2.Part5.xml # schemas/Opc.Ua.NodeSet2.Part9.xml # schemas/Opc.Ua.NodeSet2.xml # schemas/Opc.Ua.Services.wsdl # schemas/Opc.Ua.Types.bsd # schemas/Opc.Ua.Types.xsd # schemas/StatusCode.csv # schemas/UANodeSet.xsd # schemas/generate_address_space.py # schemas/generate_model.py # tests/test_client.py # tests/test_server.py # tests/tests_common.py
|
Impressive work you have done.. @cbergmiller |
oroulet
commented
Aug 1, 2018
| instanciated for every connection | ||
| defined as internal class since it needs access | ||
| to the internal server object | ||
| FIXME: find another solution |
There was a problem hiding this comment.
We need to delete that comment. It is outdated
oroulet
commented
Aug 1, 2018
| return res | ||
| return self.subscriptions[params.SubscriptionId].monitored_item_srv.delete_monitored_items( | ||
| params.MonitoredItemIds) | ||
| #with self._lock: |
There was a problem hiding this comment.
maybe remove these commented #with self._lock
There was a problem hiding this comment.
Thanks for reviewing! I will remove them once i had the time to check if they need to be replaced with a asynio.Lock
There was a problem hiding this comment.
In fact I reviewed quite a lot but could not find errors ;-) well done!
|
@cbergmiller I made a new repository https://github.com/FreeOpcUa/opcua-asyncio. You can push any further work directly to master until we have stabilized it. (Note it is up to date, all your work is in master) |
added 12 commits
August 2, 2018 14:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.