add type hints around crypto module #1714
Open
+135
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oroulet
reviewed
Oct 16, 2024
| @@ -88,7 +88,7 @@ def _process_received_data(self, data: bytes) -> None: | |||
| return | |||
| msg = self._connection.receive_from_header_and_body(header, buf) | |||
| self._process_received_message(msg) | |||
| if header.MessageType == ua.MessageType.SecureOpen: | |||
| if header.MessageType == ua.MessageType.SecureOpen and isinstance(msg,ua.Message): | |||
There was a problem hiding this comment.
that check for isinstance cannot be correct. if that is because of mypy then annotate the "recevie_from_header_xx" over
oroulet
reviewed
Oct 16, 2024
| @@ -51,7 +56,7 @@ def is_chunk_count_within_limit(self, sz: int) -> bool: | |||
| _logger.error("Number of message chunks: %s is > configured max chunk count: %s", sz, self.max_chunk_count) | |||
| return within_limit | |||
|
|
|||
| def create_acknowledge_and_set_limits(self, msg: ua.Hello) -> ua.Acknowledge: | |||
| def create_acknowledge_and_set_limits(self, msg: "ua.Hello") -> "ua.Acknowledge": | |||
There was a problem hiding this comment.
that too cannot be correct. should be possible to use from __future__ import annotations stuff to avoid adding "
There was a problem hiding this comment.
there should be no reason to use " for typing
|
@jbeckerwsi conflicts and some comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.