load_enums: skip bad enum definitions with error message #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loehnertj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #1381 :
Looking beyond the problem at hand, it might always be that a server has unexpected or corrupt data for one or more type definitions.
load_type_definitionsshould skip such definitions with an error message and continue on. This PR provides this behavior for Enum + OptionSet types.For regular structure types, this should already happen with the code as before (since there are up to 10 retries); however I didn't verify this.
The idea of raising all Exceptions together as
ExceptionGroupwas discarded for two reasons:load_type_definitionsreturns the created objects as list, which is not possible if an Exception is raised;ExceptionGroupwas introduced in Py 3.11, requiring some hack or backport to support earlier versions.