load_data_type_definitions: Accept OptionSet / Enumeration defined via StructureDefinition #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StructureDefinition instance. This kind of type definition is "unclean" but not strictly forbidden by the standard. Requires guessing of actual enum values: - Count starting at 1 for Enums - 0x1, 0x2, 0x4, ... for OptionSet
Dimfred
pushed a commit
to Dimfred/opcua-asyncio
that referenced
this pull request
Sep 19, 2023
…a StructureDefinition (FreeOpcUa#1383) * When reading Enumeration and OptionSet type definitions, also accept StructureDefinition instance. This kind of type definition is "unclean" but not strictly forbidden by the standard. Requires guessing of actual enum values: - Count starting at 1 for Enums - 0x1, 0x2, 0x4, ... for OptionSet * add test for OptionSet defined via StructureDefinition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1381:
On one server, it was observed that OptionSets are defined using a StructureDefinition instead of EnumDefinition as suggested by the standard.
This PR enables load_enums to parse such definitions and create the enum class.
Point of discussion: Since StructureField has no means of specifying the member value, it is inferred from the index of the field within the fields array:
Includes test.
Also tested against Tani Server 2.7.3 -> observed problem is fixed.