Better PhotonCamera #132
Open
Better PhotonCamera #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoguy1000
reviewed
Oct 22, 2024
Comment on lines
+95
to
+110
| new Thread(() -> { | ||
| Timer timer = new Timer(); | ||
| while (true) { | ||
| if (timer.advanceIfElapsed(10.0) && !isPhotonOk.get()) { | ||
| try { | ||
| uploadSettings(cameraIP + ":5800", | ||
| new File(Filesystem.getDeployDirectory().getAbsoluteFile(), | ||
| "photon-configs/" + cameraName + ".zip")); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); | ||
| } | ||
| } | ||
| Thread.yield(); | ||
| } | ||
| }).start(); | ||
| } |
There was a problem hiding this comment.
Should only do this if in simulation mode.
There was a problem hiding this comment.
Probably. Agreed on the separate "Vision" subsystem.
| var res = inputs.result; | ||
| if (res == null || inputs.timeSinceLastHeartbeat > 0.5) { | ||
| var res = this.camera.getLatestResult(); | ||
| if (res == null || Timer.getFPGATimestamp() - res.getTimestampSeconds() > 0.5) { |
There was a problem hiding this comment.
U should be able to use latency() > 0.5 since u have the same function below
There was a problem hiding this comment.
I think latency is actually different from this (calculated pi-side). I'll check, but I agree it should be consistent whatever we do here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we've seen with simulation stuff, not having an actual
PhotonCamerais a big barrier for using much of PhotonVision's API. This update gets us roughly the same behavior as the oldPhotonIO, but as an extension ofPhotonCamerainstead of a replacement. NowPhotonCameraWrappercontains an instance ofPhotonCamerathat could be used for simulation.