This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
filter 0 from default x data, clean up demo #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boygirl
pushed a commit
that referenced
this pull request
Dec 14, 2015
filter 0 from default x data, clean up demo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc/ @coopy or @kenwheeler
@kenwheeler reported an issue where plotting a log scale chart with no data resulted in an invalid path. This was caused by the default data having zero values, which result in
-Infinitywhen plotted on a log scale. This PR filters 0 from the default x data array so that the default data wont cause log scales to break. Data passed via props is not filtered.I would really like to be able to introspect on the type of scale currently in use. Related issue / feature request d3/d3-scale#25