Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add no literals check #510

Merged
merged 3 commits into from
Nov 13, 2024
Merged

ci: add no literals check #510

merged 3 commits into from
Nov 13, 2024

Conversation

matteo-cristino
Copy link
Contributor

  • chore: move from eslint 8 to eslint 9
  • ci: add no literals check

@matteo-cristino
Copy link
Contributor Author

Not totally sure about eslint transition to v9 since I have done it with a tool

npx @eslint/migrate-config .eslintrc.cjs

as stated here https://eslint.org/docs/latest/use/configure/migration-guide#migrate-your-config-file

@matteo-cristino
Copy link
Contributor Author

some literal strings are also set as Javascript expression, thus this test does not find them. By running

ag "{\'[^\']*\'}|{\"[^\"]*\"}"

I found also

src/routes/logs/+page.svelte
25:             <d-button href={r('/home')}> {'back'} </d-button>
26:             <d-button on:click={clear}> {'clear'} </d-button>
27:             <d-button on:click={clearPreferences}> {'clear storage'} </d-button>

src/routes/[[lang]]/(protected)/verification/results/+page.svelte
21:                     in-progress-message={'in progress'}
22:                     failure-message={'verification failed'}
23:                     session-message={'session'}

src/routes/[[lang]]/(protected)/verification/+page.svelte
69:                             color="accent">{'Choose credentials'}</d-button

src/routes/[[lang]]/(protected)/credential-offer/+page.svelte
189:                                                            <d-text class="break-words">{'c_nonce'}: {serviceResponse.c_nonce}</d-text>
191:                                                                    >{'c_nonce_expires_in'}: {serviceResponse.c_nonce_expires_in}</d-text

src/routes/[[lang]]/(protected)/wallet/+page.svelte
46:                                             expirationLabel={'Exp'}

@puria puria merged commit c6af673 into main Nov 13, 2024
4 of 7 checks passed
@puria puria deleted the ci/no_literals branch November 13, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants