bug fix for base colors with a hue and saturation of 0 returning reds

Fooidge · Oct 24, 2014 · a65e72e · a65e72e
1 parent feebad0
commit a65e72e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "pleasejs",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "homepage": "https://github.com/Fooidge/PleaseJS",
   "authors": [
     "Fooidge"

diff --git a/dist/Please.js b/dist/Please.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "pleasejs",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "description": "JS library to generate random pleasing colors/color schemes",
   "main": ".dist/Please.js",
   "scripts": {

diff --git a/src/Please.js b/src/Please.js
@@ -1,4 +1,4 @@
-/*!Please JS v0.3.0, Jordan Checkman 2014, Checkman.io, MIT License, Have fun.*/
+/*!Please JS v0.4.0, Jordan Checkman 2014, Checkman.io, MIT License, Have fun.*/
 (function( globalName, root, factory ) {
 	if ( typeof define === 'function' && define.amd ) {
 		define( [], factory );
@@ -580,7 +580,13 @@
 					value;
 				if( base_color !== null ){
 					hue = clamp( random_int( ( base_color.h - 5 ), ( base_color.h + 5 ), randomiser), 0, 360);
-					saturation = random_float( 0.4, 0.85, randomiser );
+					//fix for black/gray as a base color returning reds
+					if( base_color.s === 0 ) {
+						saturation = 0;
+					}
+					else{
+						saturation = random_float( 0.4, 0.85, randomiser );
+					}
 					value = random_float( 0.4, 0.85, randomiser );
 					color.push({
 						h: hue,