TDD / Testability #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenntt
commented
Dec 18, 2024
| @@ -19,12 +19,13 @@ test each and every part manually. You clicked on the nice TestMyCode (TMC) butt | |||
| There is a catch though: Out there in the real world, there won't be any button doing that magic for you, nor will some teacher or school | |||
| provide the tests for you, so [red]*you will be on your own*.# | |||
|
|
|||
| But fret not! Writing tests is typically much simpler than writing the actual code. At least, it is when you follow a basic set of steps: | |||
| But fret not! Writing tests is typically much simpler than writing the actual code. At least it is, when you know the anatomy of a test: | |||
There was a problem hiding this comment.
AAA is more of an organisation-thingy.
In TDD, a helpful trick to learn can be to start with thinking of the 'Assert' part.
I'd therefore avoid thinking of them in steps.
lenntt
commented
Dec 18, 2024
| @@ -14,6 +14,18 @@ toc: true | |||
|
|
|||
| :imagesdir: /prc2_web/ | |||
|
|
|||
| == Clean tests | |||
There was a problem hiding this comment.
I think FIRST principles are helpful, not sure where they fit in best
- week 1 seems pretty cramped already?
- in week 2 it might give us a nice opportunity to revisit some fundamentals like TDD and AAA ?
lenntt
commented
Dec 18, 2024
| @@ -36,7 +50,7 @@ makes the application valuable, the rest is either plumbing or already available | |||
|
|
|||
| [WARNING] | |||
| [red]*Never* let the business code _create_ its own persistence or or service object. You would | |||
| [big red]*loose control* over what flows between service and business class, | |||
| [red]*loose control* over what flows between service and business class, | |||
| and makes it [red]_unobservable_, which is bad from the testing standpoint. | |||
|
|
|||
| Instead hand the service or resource to the business, or give it some provider of a resource. | |||
There was a problem hiding this comment.
In the part below, I don't like that we focus on a class, rather than behavior (of a class).
What behavior is it we're testing/designing?
Also, I find it somewhat hard to read (I think there are different meanings used to the word 'business').
I'd suggest either:
- delete it
- work out a better option (I might give it an attempt later)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'd be happy to revert changes/move them - I'll comment inline my 'why'