Crescendo #48
Merged
Crescendo #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 92.69% 93.71% +1.02%
==========================================
Files 3 3
Lines 342 334 -8
==========================================
- Hits 317 313 -4
+ Misses 25 21 -4 ☔ View full report in Codecov by Sentry. |
web3ashlee
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Nice! Most of my comments are questions/thoughts I had while reading through this. Reviewing this was a good way to get more familiar with upgrades. I had to reference docs a few times!
highskore
reviewed
May 19, 2024
|
Leaving a note that I will be revisiting our this PR again since there have been some changes to Crescendo since I did the initial pass-through. I'll flag everyone who has commented once it is ready 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.