Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestSetCollectionExternalUrl #36

Merged
merged 2 commits into from
Dec 21, 2023
Merged

TestSetCollectionExternalUrl #36

merged 2 commits into from
Dec 21, 2023

Conversation

web3ashlee
Copy link
Contributor

@web3ashlee web3ashlee commented Dec 20, 2023 •
edited
Loading

Do we want to test that the url is what we expect? Or is this sufficient

Edit: above is included in test now

@web3ashlee web3ashlee mentioned this pull request Dec 20, 2023
Open
15 tasks
@austinkline
Copy link
Contributor

If we're setting state in a test, it's generally the case that you should assert it was updated properly

@web3ashlee
Copy link
Contributor Author

Okay this should be ready

@web3ashlee web3ashlee merged commit 216e369 into main Dec 21, 2023
1 check passed
@web3ashlee web3ashlee deleted the ash/seturl branch December 21, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinkline austinkline austinkline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@web3ashlee @austinkline