-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean shutdown #4499
base: master
Are you sure you want to change the base?
Clean shutdown #4499
Conversation
7d7da74
to
6b03635
Compare
FlowAuth Run #24001
Run Properties:
|
Project |
FlowAuth
|
Branch Review |
clean-shutdown
|
Run status |
Passed #24001
|
Run duration | 00m 47s |
Commit |
511eaf935b: Merge branch 'master' into clean-shutdown
|
Committer | Jonathan Gray |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
6b03635
to
9c589c5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4499 +/- ##
==========================================
- Coverage 92.15% 92.13% -0.02%
==========================================
Files 275 276 +1
Lines 10755 10846 +91
Branches 1297 1308 +11
==========================================
+ Hits 9911 9993 +82
- Misses 691 697 +6
- Partials 153 156 +3 ☔ View full report in Codecov by Sentry. |
466b4b5
to
0abb574
Compare
Warning Rate limit exceeded@greenape has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 51 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Closes #4053
I have:
Description
Introduces the concept that any running flowmachine session (server, in notebook, wherever) has a unique identifier, and records, in Redis, when it is actively managing a query (i.e. doing anything with a query that would trigger a state transition). This allows us to introduce an exit handler, where any queries not being managed are released for another session to work with.
This is not ready yet, because I haven't thought through all the intricacies. Be good to get some additional brain power on it.