Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean shutdown #4499

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Clean shutdown #4499

wants to merge 17 commits into from

Conversation

greenape
Copy link
Member

@greenape greenape commented Nov 8, 2021

Closes #4053

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Introduces the concept that any running flowmachine session (server, in notebook, wherever) has a unique identifier, and records, in Redis, when it is actively managing a query (i.e. doing anything with a query that would trigger a state transition). This allows us to introduce an exit handler, where any queries not being managed are released for another session to work with.

This is not ready yet, because I haven't thought through all the intricacies. Be good to get some additional brain power on it.


@greenape greenape added enhancement New feature or request FlowMachine Issues related to FlowMachine Needs Review PR that is ready for review by a human labels Nov 8, 2021
@cypress
Copy link

cypress bot commented Nov 8, 2021

FlowAuth    Run #24001

Run Properties:  status check passed Passed #24001  •  git commit 511eaf935b: Merge branch 'master' into clean-shutdown
Project FlowAuth
Branch Review clean-shutdown
Run status status check passed Passed #24001
Run duration 00m 47s
Commit git commit 511eaf935b: Merge branch 'master' into clean-shutdown
Committer Jonathan Gray
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Attention: Patch coverage is 91.08911% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.13%. Comparing base (5317388) to head (511eaf9).

Files with missing lines Patch % Lines
flowmachine/flowmachine/core/context.py 76.47% 3 Missing and 1 partial ⚠️
flowmachine/flowmachine/core/query_manager.py 91.89% 3 Missing ⚠️
flowmachine/flowmachine/core/init.py 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4499      +/-   ##
==========================================
- Coverage   92.15%   92.13%   -0.02%     
==========================================
  Files         275      276       +1     
  Lines       10755    10846      +91     
  Branches     1297     1308      +11     
==========================================
+ Hits         9911     9993      +82     
- Misses        691      697       +6     
- Partials      153      156       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greenape greenape force-pushed the clean-shutdown branch 2 times, most recently from 466b4b5 to 0abb574 Compare April 29, 2022 08:30
Copy link
Contributor

coderabbitai bot commented Nov 5, 2024

Warning

Rate limit exceeded

@greenape has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 51 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5317388 and 511eaf9.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowMachine Issues related to FlowMachine Needs Review PR that is ready for review by a human
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck executing
3 participants