Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: deprecate a public attribute #144

Merged
merged 1 commit into from
Sep 30, 2024
Merged

deprecate: deprecate a public attribute #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/flowingcode/vaadin/addons/gridexporter/DocxStreamResourceWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ private void fillData(XWPFTable table, XWPFTableCell dataCell, DataProvider<T, ?
Iterator<Column<T>> iterator = exporter.getColumns().iterator();
while (iterator.hasNext()) {
iterator.next();
// preserve increment for deprecated attribute
exporter.totalcells = exporter.totalcells + 1;
currentRow.createCell();
}
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ public class GridExporter<T> implements Serializable {

SerializableSupplier<String> nullValueSupplier;

/** @deprecated. This attribute is incremented only when exporting DOCX, but it's never reset. */
@Deprecated(since = "2.5.0", forRemoval = true)
paodb marked this conversation as resolved.
Show resolved Hide resolved
public int totalcells = 0;

private ButtonsAlignment buttonsAlignment = ButtonsAlignment.RIGHT;
Expand Down
Loading