[Bug] Goals: Fix schedules 'in between' calculation (actualbudget#1753)

* fix in between calculation * release note
FlorianLang06 · Oct 6, 2023 · 7be4f8b · 7be4f8b
1 parent 04dec4a
commit 7be4f8b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/packages/loot-core/src/server/budget/goaltemplates.ts b/packages/loot-core/src/server/budget/goaltemplates.ts
@@ -645,7 +645,12 @@ async function applyCategoryTemplate(
             let conditions = rule.serialize().conditions;
             let { date: dateConditions, amount: amountCondition } =
               extractScheduleConds(conditions);
-            let target = -amountCondition.value;
+            let target =
+              amountCondition.op === 'isbetween'
+                ? -Math.round(
+                    amountCondition.value.num1 + amountCondition.value.num2,
+                  ) / 2
+                : -amountCondition.value;
             let next_date_string = getNextDate(
               dateConditions,
               monthUtils._parse(current_month),
@@ -682,7 +687,7 @@ async function applyCategoryTemplate(
                   monthUtils._parse(current_month),
                 );
                 while (next_date < next_month) {
-                  monthlyTarget += amountCondition.value;
+                  monthlyTarget += -target;
                   next_date = monthUtils.addDays(next_date, 1);
                   next_date = getNextDate(
                     dateConditions,

diff --git a/upcoming-release-notes/1753.md b/upcoming-release-notes/1753.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [shall0pass]
+---
+
+Goals - Fix schedules 'in between' calculation