ESLint no-default-exports 7 (actualbudget#2169)

* Fix default imports * Fix manager Modals import * ESLint no default exports 7 * Release notes
FlorianLang06 · Jan 6, 2024 · 6acf75f · 6acf75f
1 parent 8b9c316
commit 6acf75f
Show file tree

Hide file tree

Showing 62 changed files with 167 additions and 182 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -246,9 +246,9 @@ module.exports = {
         './packages/crdt/**/*',
         './packages/desktop-client/src/*',
         './packages/desktop-client/src/components/*',
-        // './packages/desktop-client/src/components/accounts/**/*',
-        // './packages/desktop-client/src/components/autocomplete/**/*',
-        // './packages/desktop-client/src/components/budget/**/*',
+        './packages/desktop-client/src/components/accounts/**/*',
+        './packages/desktop-client/src/components/autocomplete/**/*',
+        './packages/desktop-client/src/components/budget/**/*',
         './packages/desktop-client/src/components/common/**/*',
         // './packages/desktop-client/src/components/filters/**/*',
         // './packages/desktop-client/src/components/gocardless/**/*',

diff --git a/packages/desktop-client/src/components/Titlebar.tsx b/packages/desktop-client/src/components/Titlebar.tsx
@@ -25,7 +25,7 @@ import ViewShow from '../icons/v2/ViewShow';
 import { useResponsive } from '../ResponsiveProvider';
 import { theme, type CSSProperties, styles } from '../style';
 
-import AccountSyncCheck from './accounts/AccountSyncCheck';
+import { AccountSyncCheck } from './accounts/AccountSyncCheck';
 import { AnimatedRefresh } from './AnimatedRefresh';
 import { MonthCountSelector } from './budget/MonthCountSelector';
 import { Button, ButtonWithLoading } from './common/Button';

diff --git a/packages/desktop-client/src/components/accounts/Account.jsx b/packages/desktop-client/src/components/accounts/Account.jsx
@@ -1473,7 +1473,7 @@ function AccountHack(props) {
   );
 }
 
-export default function Account() {
+export function Account() {
   const params = useParams();
   const location = useLocation();
 

diff --git a/packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx b/packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx
@@ -48,7 +48,7 @@ function getErrorMessage(type, code) {
   );
 }
 
-export default function AccountSyncCheck() {
+export function AccountSyncCheck() {
   const accounts = useSelector(state => state.queries.accounts);
   const failedAccounts = useSelector(state => state.account.failedAccounts);
   const { unlinkAccount, pushModal } = useActions();

diff --git a/packages/desktop-client/src/components/accounts/MobileAccount.jsx b/packages/desktop-client/src/components/accounts/MobileAccount.jsx
@@ -24,7 +24,7 @@ import useNavigate from '../../hooks/useNavigate';
 import { useSetThemeColor } from '../../hooks/useSetThemeColor';
 import { theme } from '../../style';
 
-import AccountDetails from './MobileAccountDetails';
+import { AccountDetails } from './MobileAccountDetails';
 
 const getSchedulesTransform = memoizeOne((id, hasSearch) => {
   let filter = queries.getAccountFilter(id, '_account');
@@ -68,7 +68,7 @@ function PreviewTransactions({ accountId, children }) {
 
 let paged;
 
-export default function Account(props) {
+export function Account(props) {
   const accounts = useSelector(state => state.queries.accounts);
 
   const navigate = useNavigate();

diff --git a/packages/desktop-client/src/components/accounts/MobileAccountDetails.jsx b/packages/desktop-client/src/components/accounts/MobileAccountDetails.jsx
@@ -61,7 +61,7 @@ function TransactionSearchInput({ accountName, onSearch }) {
   );
 }
 
-export default function AccountDetails({
+export function AccountDetails({
   account,
   prependTransactions,
   transactions,

diff --git a/packages/desktop-client/src/components/accounts/MobileAccounts.jsx b/packages/desktop-client/src/components/accounts/MobileAccounts.jsx
@@ -215,7 +215,7 @@ function AccountList({
   );
 }
 
-export default function Accounts() {
+export function Accounts() {
   const accounts = useSelector(state => state.queries.accounts);
   const newTransactions = useSelector(state => state.queries.newTransactions);
   const updatedAccounts = useSelector(state => state.queries.updatedAccounts);

diff --git a/packages/desktop-client/src/components/autocomplete/AccountAutocomplete.tsx b/packages/desktop-client/src/components/autocomplete/AccountAutocomplete.tsx
@@ -9,7 +9,7 @@ import { useResponsive } from '../../ResponsiveProvider';
 import { type CSSProperties, theme } from '../../style';
 import { View } from '../common/View';
 
-import Autocomplete from './Autocomplete';
+import { Autocomplete } from './Autocomplete';
 
 function AccountList({
   items,
@@ -77,7 +77,7 @@ type AccountAutoCompleteProps = {
   closeOnBlur?: boolean;
 } & ComponentProps<typeof Autocomplete>;
 
-export default function AccountAutocomplete({
+export function AccountAutocomplete({
   embedded,
   includeClosedAccounts = true,
   renderAccountItemGroupHeader,

diff --git a/packages/desktop-client/src/components/autocomplete/Autocomplete.tsx b/packages/desktop-client/src/components/autocomplete/Autocomplete.tsx
@@ -728,7 +728,7 @@ function isMultiAutocomplete<T extends Item>(
   return multi;
 }
 
-export default function Autocomplete<T extends Item>({
+export function Autocomplete<T extends Item>({
   multi,
   ...props
 }: AutocompleteProps<T> & { multi?: boolean }) {

diff --git a/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx b/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx
@@ -20,7 +20,7 @@ import { type CSSProperties, theme } from '../../style';
 import { Text } from '../common/Text';
 import { View } from '../common/View';
 
-import Autocomplete, { defaultFilterSuggestion } from './Autocomplete';
+import { Autocomplete, defaultFilterSuggestion } from './Autocomplete';
 
 export type CategoryListProps = {
   items: Array<CategoryEntity & { group?: CategoryGroupEntity }>;
@@ -107,7 +107,7 @@ type CategoryAutocompleteProps = ComponentProps<typeof Autocomplete> & {
   renderCategoryItem?: (props: CategoryItemProps) => ReactNode;
 };
 
-export default function CategoryAutocomplete({
+export function CategoryAutocomplete({
   categoryGroups,
   showSplitOption,
   embedded,

diff --git a/packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx b/packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx
@@ -26,7 +26,8 @@ import { type CSSProperties, theme } from '../../style';
 import { Button } from '../common/Button';
 import { View } from '../common/View';
 
-import Autocomplete, {
+import {
+  Autocomplete,
   defaultFilterSuggestion,
   AutocompleteFooter,
 } from './Autocomplete';
@@ -167,7 +168,7 @@ type PayeeAutocompleteProps = {
   payees?: PayeeEntity[];
 };
 
-export default function PayeeAutocomplete({
+export function PayeeAutocomplete({
   value,
   inputProps,
   showMakeTransfer = true,

diff --git a/packages/desktop-client/src/components/autocomplete/SavedFilterAutocomplete.tsx b/packages/desktop-client/src/components/autocomplete/SavedFilterAutocomplete.tsx
@@ -6,7 +6,7 @@ import { type TransactionFilterEntity } from 'loot-core/src/types/models';
 import { theme } from '../../style';
 import { View } from '../common/View';
 
-import Autocomplete from './Autocomplete';
+import { Autocomplete } from './Autocomplete';
 
 type FilterListProps<T> = {
   items: T[];
@@ -60,7 +60,7 @@ type SavedFilterAutocompleteProps = {
   embedded?: boolean;
 } & ComponentProps<typeof Autocomplete<TransactionFilterEntity>>;
 
-export default function SavedFilterAutocomplete({
+export function SavedFilterAutocomplete({
   embedded,
   ...props
 }: SavedFilterAutocompleteProps) {

diff --git a/packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx b/packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx
@@ -19,7 +19,7 @@ type BalanceWithCarryoverProps = {
   balanceStyle?: CSSProperties;
   carryoverStyle?: CSSProperties;
 };
-export default function BalanceWithCarryover({
+export function BalanceWithCarryover({
   carryover,
   balance,
   goal,

diff --git a/packages/desktop-client/src/components/budget/BudgetCategories.jsx b/packages/desktop-client/src/components/budget/BudgetCategories.jsx
@@ -5,16 +5,16 @@ import { View } from '../common/View';
 import { DropHighlightPosContext } from '../sort';
 import { Row } from '../table';
 
-import ExpenseCategory from './ExpenseCategory';
-import ExpenseGroup from './ExpenseGroup';
-import IncomeCategory from './IncomeCategory';
-import IncomeGroup from './IncomeGroup';
-import IncomeHeader from './IncomeHeader';
-import SidebarCategory from './SidebarCategory';
-import SidebarGroup from './SidebarGroup';
+import { ExpenseCategory } from './ExpenseCategory';
+import { ExpenseGroup } from './ExpenseGroup';
+import { IncomeCategory } from './IncomeCategory';
+import { IncomeGroup } from './IncomeGroup';
+import { IncomeHeader } from './IncomeHeader';
+import { SidebarCategory } from './SidebarCategory';
+import { SidebarGroup } from './SidebarGroup';
 import { separateGroups } from './util';
 
-const BudgetCategories = memo(
+export const BudgetCategories = memo(
   ({
     categoryGroups,
     newCategoryForGroup,
@@ -313,5 +313,3 @@ const BudgetCategories = memo(
     );
   },
 );
-
-export default BudgetCategories;
diff --git a/packages/desktop-client/src/components/budget/BudgetPageHeader.tsx b/packages/desktop-client/src/components/budget/BudgetPageHeader.tsx
@@ -14,7 +14,7 @@ type BudgetPageHeaderProps = {
   monthBounds: ComponentProps<typeof MonthPicker>['monthBounds'];
 };
 
-const BudgetPageHeader = memo<BudgetPageHeaderProps>(
+export const BudgetPageHeader = memo<BudgetPageHeaderProps>(
   ({ startMonth, onMonthSelect, numMonths, monthBounds }) => {
     function getValidMonth(month) {
       const start = monthBounds.start;
@@ -43,5 +43,3 @@ const BudgetPageHeader = memo<BudgetPageHeaderProps>(
     );
   },
 );
-
-export default BudgetPageHeader;
diff --git a/packages/desktop-client/src/components/budget/BudgetSummaries.tsx b/packages/desktop-client/src/components/budget/BudgetSummaries.tsx
@@ -15,16 +15,14 @@ import useResizeObserver from '../../hooks/useResizeObserver';
 import { View } from '../common/View';
 
 import { MonthsContext } from './MonthsContext';
-import type ReportBudgetSummary from './report/budgetsummary/BudgetSummary';
-import type RolloverBudgetSummary from './rollover/budgetsummary/BudgetSummary';
+import { type BudgetSummary as ReportBudgetSummary } from './report/budgetsummary/BudgetSummary';
+import { type BudgetSummary as RolloverBudgetSummary } from './rollover/budgetsummary/BudgetSummary';
 
 type BudgetSummariesProps = {
   SummaryComponent: typeof ReportBudgetSummary | typeof RolloverBudgetSummary;
 };
 
-export default function BudgetSummaries({
-  SummaryComponent,
-}: BudgetSummariesProps) {
+export function BudgetSummaries({ SummaryComponent }: BudgetSummariesProps) {
   const { months } = useContext(MonthsContext);
 
   const [widthState, setWidthState] = useState(0);

diff --git a/packages/desktop-client/src/components/budget/BudgetTable.jsx b/packages/desktop-client/src/components/budget/BudgetTable.jsx
@@ -6,13 +6,13 @@ import { theme, styles } from '../../style';
 import { View } from '../common/View';
 import { IntersectionBoundary } from '../tooltips';
 
-import BudgetCategories from './BudgetCategories';
-import BudgetSummaries from './BudgetSummaries';
-import BudgetTotals from './BudgetTotals';
+import { BudgetCategories } from './BudgetCategories';
+import { BudgetSummaries } from './BudgetSummaries';
+import { BudgetTotals } from './BudgetTotals';
 import { MonthsProvider } from './MonthsContext';
 import { findSortDown, findSortUp, getScrollbarWidth } from './util';
 
-class BudgetTable extends Component {
+export class BudgetTable extends Component {
   constructor(props) {
     super(props);
     this.budgetCategoriesRef = createRef();
@@ -285,5 +285,3 @@ class BudgetTable extends Component {
     );
   }
 }
-
-export default BudgetTable;
diff --git a/packages/desktop-client/src/components/budget/BudgetTotals.tsx b/packages/desktop-client/src/components/budget/BudgetTotals.tsx
@@ -7,7 +7,7 @@ import { Menu } from '../common/Menu';
 import { View } from '../common/View';
 import { Tooltip } from '../tooltips';
 
-import RenderMonths from './RenderMonths';
+import { RenderMonths } from './RenderMonths';
 import { getScrollbarWidth } from './util';
 
 type BudgetTotalsProps = {
@@ -17,7 +17,7 @@ type BudgetTotalsProps = {
   collapseAllCategories: () => void;
 };
 
-const BudgetTotals = memo(function BudgetTotals({
+export const BudgetTotals = memo(function BudgetTotals({
   MonthComponent,
   toggleHiddenCategories,
   expandAllCategories,
@@ -109,5 +109,3 @@ const BudgetTotals = memo(function BudgetTotals({
     </View>
   );
 });
-
-export default BudgetTotals;
diff --git a/packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx b/packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx
@@ -6,8 +6,8 @@ import { useActions } from '../../hooks/useActions';
 import { View } from '../common/View';
 
 import { useBudgetMonthCount } from './BudgetMonthCountContext';
-import BudgetPageHeader from './BudgetPageHeader';
-import BudgetTable from './BudgetTable';
+import { BudgetPageHeader } from './BudgetPageHeader';
+import { BudgetTable } from './BudgetTable';
 
 function getNumPossibleMonths(width: number) {
   const estimatedTableWidth = width - 200;
@@ -100,19 +100,20 @@ const DynamicBudgetTableInner = forwardRef<
   },
 );
 
-export default forwardRef<BudgetTable, DynamicBudgetTableInnerProps>(
-  (props, ref) => {
-    return (
-      <AutoSizer>
-        {({ width, height }) => (
-          <DynamicBudgetTableInner
-            ref={ref}
-            width={width}
-            height={height}
-            {...props}
-          />
-        )}
-      </AutoSizer>
-    );
-  },
-);
+export const DynamicBudgetTable = forwardRef<
+  BudgetTable,
+  DynamicBudgetTableInnerProps
+>((props, ref) => {
+  return (
+    <AutoSizer>
+      {({ width, height }) => (
+        <DynamicBudgetTableInner
+          ref={ref}
+          width={width}
+          height={height}
+          {...props}
+        />
+      )}
+    </AutoSizer>
+  );
+});
diff --git a/packages/desktop-client/src/components/budget/ExpenseCategory.tsx b/packages/desktop-client/src/components/budget/ExpenseCategory.tsx
@@ -14,8 +14,8 @@ import {
 } from '../sort';
 import { Row } from '../table';
 
-import RenderMonths from './RenderMonths';
-import SidebarCategory from './SidebarCategory';
+import { RenderMonths } from './RenderMonths';
+import { SidebarCategory } from './SidebarCategory';
 
 type ExpenseCategoryProps = {
   cat: CategoryEntity;
@@ -32,7 +32,7 @@ type ExpenseCategoryProps = {
   onReorder: OnDropCallback;
 };
 
-function ExpenseCategory({
+export function ExpenseCategory({
   cat,
   editingCell,
   dragState,
@@ -108,5 +108,3 @@ function ExpenseCategory({
     </Row>
   );
 }
-
-export default ExpenseCategory;
diff --git a/packages/desktop-client/src/components/budget/ExpenseGroup.tsx b/packages/desktop-client/src/components/budget/ExpenseGroup.tsx
@@ -12,8 +12,8 @@ import {
 } from '../sort';
 import { Row, ROW_HEIGHT } from '../table';
 
-import RenderMonths from './RenderMonths';
-import SidebarGroup from './SidebarGroup';
+import { RenderMonths } from './RenderMonths';
+import { SidebarGroup } from './SidebarGroup';
 
 type ExpenseGroupProps = {
   group: ComponentProps<typeof SidebarGroup>['group'];
@@ -33,7 +33,7 @@ type ExpenseGroupProps = {
   onShowNewCategory?: ComponentProps<typeof SidebarGroup>['onShowNewCategory'];
 };
 
-function ExpenseGroup({
+export function ExpenseGroup({
   group,
   collapsed,
   editingCell,
@@ -131,5 +131,3 @@ function ExpenseGroup({
     </Row>
   );
 }
-
-export default ExpenseGroup;