ESLint no default exports 4 (actualbudget#2118)

* ESLint no-default-exports part 4 * Fix default imports * Fix default imports * Fix manager Modals import * Release notes
FlorianLang06 · Jan 6, 2024 · 47f1161 · 47f1161
1 parent 3aaf2a9
commit 47f1161
Show file tree

Hide file tree

Showing 68 changed files with 111 additions and 100 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -267,6 +267,15 @@ module.exports = {
         './packages/desktop-client/src/components/common/LinkButton.tsx',
         './packages/desktop-client/src/components/common/Menu.tsx',
         './packages/desktop-client/src/components/common/MenuTooltip.tsx',
+        './packages/desktop-client/src/components/common/MenuButton.tsx',
+        './packages/desktop-client/src/components/common/Modal.tsx',
+        './packages/desktop-client/src/components/common/Paragraph.tsx',
+        './packages/desktop-client/src/components/common/Search.tsx',
+        './packages/desktop-client/src/components/common/Select.tsx',
+        './packages/desktop-client/src/components/common/Stack.tsx',
+        // './packages/desktop-client/src/components/common/Text.tsx',
+        './packages/desktop-client/src/components/common/TextOneLine.tsx',
+        // './packages/desktop-client/src/components/common/View.tsx',
         // './packages/desktop-client/src/components/common/**/*',
         // './packages/desktop-client/src/components/filters/**/*',
         // './packages/desktop-client/src/components/gocardless/**/*',

diff --git a/packages/desktop-client/src/components/FatalError.tsx b/packages/desktop-client/src/components/FatalError.tsx
@@ -4,9 +4,9 @@ import { Block } from './common/Block';
 import { Button } from './common/Button';
 import { ExternalLink } from './common/ExternalLink';
 import { LinkButton } from './common/LinkButton';
-import Modal from './common/Modal';
-import Paragraph from './common/Paragraph';
-import Stack from './common/Stack';
+import { Modal } from './common/Modal';
+import { Paragraph } from './common/Paragraph';
+import { Stack } from './common/Stack';
 import Text from './common/Text';
 import View from './common/View';
 import { Checkbox } from './forms';

diff --git a/packages/desktop-client/src/components/ManageRules.tsx b/packages/desktop-client/src/components/ManageRules.tsx
@@ -22,8 +22,8 @@ import { theme } from '../style';
 
 import { Button } from './common/Button';
 import { ExternalLink } from './common/ExternalLink';
-import Search from './common/Search';
-import Stack from './common/Stack';
+import { Search } from './common/Search';
+import { Stack } from './common/Stack';
 import Text from './common/Text';
 import View from './common/View';
 import RulesHeader from './rules/RulesHeader';

diff --git a/packages/desktop-client/src/components/Notifications.tsx b/packages/desktop-client/src/components/Notifications.tsx
@@ -16,7 +16,7 @@ import { styles, theme, type CSSProperties } from '../style';
 import { Button, ButtonWithLoading } from './common/Button';
 import { ExternalLink } from './common/ExternalLink';
 import { LinkButton } from './common/LinkButton';
-import Stack from './common/Stack';
+import { Stack } from './common/Stack';
 import Text from './common/Text';
 import View from './common/View';
 

diff --git a/packages/desktop-client/src/components/Titlebar.tsx b/packages/desktop-client/src/components/Titlebar.tsx
@@ -31,7 +31,7 @@ import { MonthCountSelector } from './budget/MonthCountSelector';
 import { Button, ButtonWithLoading } from './common/Button';
 import { ExternalLink } from './common/ExternalLink';
 import { Link } from './common/Link';
-import Paragraph from './common/Paragraph';
+import { Paragraph } from './common/Paragraph';
 import Text from './common/Text';
 import View from './common/View';
 import { KeyHandlers } from './KeyHandlers';

diff --git a/packages/desktop-client/src/components/accounts/Header.jsx b/packages/desktop-client/src/components/accounts/Header.jsx
@@ -13,10 +13,10 @@ import { Button } from '../common/Button';
 import { InitialFocus } from '../common/InitialFocus';
 import { Input } from '../common/Input';
 import { Menu } from '../common/Menu';
-import MenuButton from '../common/MenuButton';
+import { MenuButton } from '../common/MenuButton';
 import { MenuTooltip } from '../common/MenuTooltip';
-import Search from '../common/Search';
-import Stack from '../common/Stack';
+import { Search } from '../common/Search';
+import { Stack } from '../common/Stack';
 import View from '../common/View';
 import { FilterButton } from '../filters/FiltersMenu';
 import { FiltersStack } from '../filters/SavedFilters';

diff --git a/packages/desktop-client/src/components/accounts/MobileAccounts.jsx b/packages/desktop-client/src/components/accounts/MobileAccounts.jsx
@@ -11,7 +11,7 @@ import Add from '../../icons/v1/Add';
 import { theme, styles } from '../../style';
 import { Button } from '../common/Button';
 import Text from '../common/Text';
-import TextOneLine from '../common/TextOneLine';
+import { TextOneLine } from '../common/TextOneLine';
 import View from '../common/View';
 import { Page } from '../Page';
 import PullToRefresh from '../responsive/PullToRefresh';

diff --git a/packages/desktop-client/src/components/budget/report/budgetsummary/BudgetSummary.tsx b/packages/desktop-client/src/components/budget/report/budgetsummary/BudgetSummary.tsx
@@ -11,7 +11,7 @@ import ArrowButtonUp1 from '../../../../icons/v2/ArrowButtonUp1';
 import { theme, styles } from '../../../../style';
 import { Button } from '../../../common/Button';
 import { Menu } from '../../../common/Menu';
-import Stack from '../../../common/Stack';
+import { Stack } from '../../../common/Stack';
 import View from '../../../common/View';
 import { NotesButton } from '../../../NotesButton';
 import NamespaceContext from '../../../spreadsheet/NamespaceContext';

diff --git a/packages/desktop-client/src/components/common/MenuButton.tsx b/packages/desktop-client/src/components/common/MenuButton.tsx
@@ -4,7 +4,7 @@ import DotsHorizontalTriple from '../../icons/v1/DotsHorizontalTriple';
 
 import { Button } from './Button';
 
-export default function MenuButton({ onClick }) {
+export function MenuButton({ onClick }) {
   return (
     <Button type="bare" onClick={onClick} aria-label="Menu">
       <DotsHorizontalTriple

diff --git a/packages/desktop-client/src/components/common/Modal.tsx b/packages/desktop-client/src/components/common/Modal.tsx
@@ -49,7 +49,7 @@ export type ModalProps = {
   onTitleUpdate?: (title: string) => void;
 };
 
-const Modal = ({
+export const Modal = ({
   title,
   isCurrent,
   isHidden,
@@ -427,5 +427,3 @@ export const ModalButtons = ({
     </View>
   );
 };
-
-export default Modal;
diff --git a/packages/desktop-client/src/components/common/Paragraph.tsx b/packages/desktop-client/src/components/common/Paragraph.tsx
@@ -9,7 +9,7 @@ type ParagraphProps = HTMLProps<HTMLDivElement> & {
   isLast?: boolean;
 };
 
-export default function Paragraph({
+export function Paragraph({
   style,
   isLast,
   children,

diff --git a/packages/desktop-client/src/components/common/Search.tsx b/packages/desktop-client/src/components/common/Search.tsx
@@ -16,7 +16,7 @@ type SearchProps = {
   width?: number;
 };
 
-export default function Search({
+export function Search({
   inputRef,
   value,
   onChange,

diff --git a/packages/desktop-client/src/components/common/Select.tsx b/packages/desktop-client/src/components/common/Select.tsx
@@ -38,7 +38,7 @@ type SelectProps<Value extends string> = {
  * // <Select options={[['1', 'Option 1'], ['2', 'Option 2']]} value="3" defaultLabel="Select an option"  onChange={handleOnChange} />
  */
 
-export default function Select<Value extends string>({
+export function Select<Value extends string>({
   bare,
   options,
   value,

diff --git a/packages/desktop-client/src/components/common/Stack.tsx b/packages/desktop-client/src/components/common/Stack.tsx
@@ -36,7 +36,7 @@ type StackProps = ComponentProps<typeof View> & {
   spacing?: number;
   debug?: boolean;
 };
-const Stack = forwardRef<HTMLDivElement, StackProps>(
+export const Stack = forwardRef<HTMLDivElement, StackProps>(
   (
     {
       direction = 'column',
@@ -91,5 +91,3 @@ const Stack = forwardRef<HTMLDivElement, StackProps>(
     );
   },
 );
-
-export default Stack;
diff --git a/packages/desktop-client/src/components/common/TextOneLine.tsx b/packages/desktop-client/src/components/common/TextOneLine.tsx
@@ -4,7 +4,7 @@ import Text from './Text';
 
 type TextOneLineProps = ComponentProps<typeof Text>;
 
-export default function TextOneLine({ children, ...props }: TextOneLineProps) {
+export function TextOneLine({ children, ...props }: TextOneLineProps) {
   return (
     <Text
       {...props}

diff --git a/packages/desktop-client/src/components/filters/FiltersMenu.jsx b/packages/desktop-client/src/components/filters/FiltersMenu.jsx
@@ -28,8 +28,8 @@ import { theme } from '../../style';
 import { Button } from '../common/Button';
 import { HoverTarget } from '../common/HoverTarget';
 import { Menu } from '../common/Menu';
-import Select from '../common/Select';
-import Stack from '../common/Stack';
+import { Select } from '../common/Select';
+import { Stack } from '../common/Stack';
 import Text from '../common/Text';
 import View from '../common/View';
 import Value from '../rules/Value';

diff --git a/packages/desktop-client/src/components/filters/SavedFilters.jsx b/packages/desktop-client/src/components/filters/SavedFilters.jsx
@@ -7,7 +7,7 @@ import { theme } from '../../style';
 import { Button } from '../common/Button';
 import { Menu } from '../common/Menu';
 import { MenuTooltip } from '../common/MenuTooltip';
-import Stack from '../common/Stack';
+import { Stack } from '../common/Stack';
 import Text from '../common/Text';
 import View from '../common/View';
 import { FormField, FormLabel } from '../forms';

diff --git a/packages/desktop-client/src/components/gocardless/GoCardlessLink.tsx b/packages/desktop-client/src/components/gocardless/GoCardlessLink.tsx
@@ -1,7 +1,7 @@
 import React from 'react';
 
-import Modal from '../common/Modal';
-import Paragraph from '../common/Paragraph';
+import { Modal } from '../common/Modal';
+import { Paragraph } from '../common/Paragraph';
 import View from '../common/View';
 
 export default function GoCardlessLink() {

diff --git a/packages/desktop-client/src/components/manager/DeleteFile.tsx b/packages/desktop-client/src/components/manager/DeleteFile.tsx
@@ -6,7 +6,7 @@ import { type BoundActions } from '../../hooks/useActions';
 import { theme } from '../../style';
 import { type CommonModalProps } from '../../types/modals';
 import { ButtonWithLoading } from '../common/Button';
-import Modal from '../common/Modal';
+import { Modal } from '../common/Modal';
 import Text from '../common/Text';
 import View from '../common/View';
 

diff --git a/packages/desktop-client/src/components/manager/Import.tsx b/packages/desktop-client/src/components/manager/Import.tsx
@@ -5,7 +5,7 @@ import { styles, theme } from '../../style';
 import { type CommonModalProps } from '../../types/modals';
 import { Block } from '../common/Block';
 import { Button } from '../common/Button';
-import Modal from '../common/Modal';
+import { Modal } from '../common/Modal';
 import Text from '../common/Text';
 import View from '../common/View';
 

diff --git a/packages/desktop-client/src/components/manager/ImportActual.tsx b/packages/desktop-client/src/components/manager/ImportActual.tsx
@@ -6,8 +6,8 @@ import { importBudget } from 'loot-core/src/client/actions/budgets';
 import { styles, theme } from '../../style';
 import { Block } from '../common/Block';
 import { ButtonWithLoading } from '../common/Button';
-import Modal, { type ModalProps } from '../common/Modal';
-import Paragraph from '../common/Paragraph';
+import { Modal, type ModalProps } from '../common/Modal';
+import { Paragraph } from '../common/Paragraph';
 import View from '../common/View';
 
 function getErrorMessage(error: string): string {

diff --git a/packages/desktop-client/src/components/manager/ImportYNAB4.tsx b/packages/desktop-client/src/components/manager/ImportYNAB4.tsx
@@ -6,8 +6,8 @@ import { importBudget } from 'loot-core/src/client/actions/budgets';
 import { styles, theme } from '../../style';
 import { Block } from '../common/Block';
 import { ButtonWithLoading } from '../common/Button';
-import Modal, { type ModalProps } from '../common/Modal';
-import Paragraph from '../common/Paragraph';
+import { Modal, type ModalProps } from '../common/Modal';
+import { Paragraph } from '../common/Paragraph';
 import View from '../common/View';
 
 function getErrorMessage(error: string): string {

diff --git a/packages/desktop-client/src/components/manager/ImportYNAB5.tsx b/packages/desktop-client/src/components/manager/ImportYNAB5.tsx
@@ -7,8 +7,8 @@ import { styles, theme } from '../../style';
 import { Block } from '../common/Block';
 import { ButtonWithLoading } from '../common/Button';
 import { ExternalLink } from '../common/ExternalLink';
-import Modal, { type ModalProps } from '../common/Modal';
-import Paragraph from '../common/Paragraph';
+import { Modal, type ModalProps } from '../common/Modal';
+import { Paragraph } from '../common/Paragraph';
 import View from '../common/View';
 
 function getErrorMessage(error: string): string {

diff --git a/packages/desktop-client/src/components/manager/WelcomeScreen.tsx b/packages/desktop-client/src/components/manager/WelcomeScreen.tsx
@@ -4,7 +4,7 @@ import { useActions } from '../../hooks/useActions';
 import { styles, theme } from '../../style';
 import { Button } from '../common/Button';
 import { ExternalLink } from '../common/ExternalLink';
-import Paragraph from '../common/Paragraph';
+import { Paragraph } from '../common/Paragraph';
 import Text from '../common/Text';
 import View from '../common/View';
 

diff --git a/packages/desktop-client/src/components/manager/subscribe/Bootstrap.tsx b/packages/desktop-client/src/components/manager/subscribe/Bootstrap.tsx
@@ -8,7 +8,7 @@ import { send } from 'loot-core/src/platform/client/fetch';
 import { theme } from '../../../style';
 import { Button } from '../../common/Button';
 import { ExternalLink } from '../../common/ExternalLink';
-import Paragraph from '../../common/Paragraph';
+import { Paragraph } from '../../common/Paragraph';
 import Text from '../../common/Text';
 import View from '../../common/View';
 

diff --git a/packages/desktop-client/src/components/modals/CategoryGroupMenu.tsx b/packages/desktop-client/src/components/modals/CategoryGroupMenu.tsx
@@ -15,7 +15,7 @@ import { type CSSProperties, styles, theme } from '../../style';
 import { type CommonModalProps } from '../../types/modals';
 import { Button } from '../common/Button';
 import { Menu } from '../common/Menu';
-import Modal from '../common/Modal';
+import { Modal } from '../common/Modal';
 import View from '../common/View';
 import { Notes } from '../Notes';
 import { Tooltip } from '../tooltips';

diff --git a/packages/desktop-client/src/components/modals/CategoryMenu.tsx b/packages/desktop-client/src/components/modals/CategoryMenu.tsx
@@ -14,7 +14,7 @@ import { type CSSProperties, styles, theme } from '../../style';
 import { type CommonModalProps } from '../../types/modals';
 import { Button } from '../common/Button';
 import { Menu } from '../common/Menu';
-import Modal from '../common/Modal';
+import { Modal } from '../common/Modal';
 import View from '../common/View';
 import { Notes } from '../Notes';
 import { Tooltip } from '../tooltips';

diff --git a/packages/desktop-client/src/components/modals/CloseAccount.tsx b/packages/desktop-client/src/components/modals/CloseAccount.tsx
@@ -14,8 +14,8 @@ import CategoryAutocomplete from '../autocomplete/CategoryAutocomplete';
 import { Button } from '../common/Button';
 import { FormError } from '../common/FormError';
 import { LinkButton } from '../common/LinkButton';
-import Modal from '../common/Modal';
-import Paragraph from '../common/Paragraph';
+import { Modal } from '../common/Modal';
+import { Paragraph } from '../common/Paragraph';
 import Text from '../common/Text';
 import View from '../common/View';
 

diff --git a/packages/desktop-client/src/components/modals/ConfirmCategoryDelete.tsx b/packages/desktop-client/src/components/modals/ConfirmCategoryDelete.tsx
@@ -7,7 +7,7 @@ import { type CommonModalProps } from '../../types/modals';
 import CategoryAutocomplete from '../autocomplete/CategoryAutocomplete';
 import { Block } from '../common/Block';
 import { Button } from '../common/Button';
-import Modal from '../common/Modal';
+import { Modal } from '../common/Modal';
 import Text from '../common/Text';
 import View from '../common/View';
 

diff --git a/packages/desktop-client/src/components/modals/ConfirmTransactionEdit.tsx b/packages/desktop-client/src/components/modals/ConfirmTransactionEdit.tsx
@@ -3,7 +3,7 @@ import React from 'react';
 import { type CommonModalProps } from '../../types/modals';
 import { Block } from '../common/Block';
 import { Button } from '../common/Button';
-import Modal from '../common/Modal';
+import { Modal } from '../common/Modal';
 import View from '../common/View';
 
 type ConfirmTransactionEditProps = {

diff --git a/packages/desktop-client/src/components/modals/CreateAccount.tsx b/packages/desktop-client/src/components/modals/CreateAccount.tsx
@@ -8,8 +8,8 @@ import { theme } from '../../style';
 import { type CommonModalProps } from '../../types/modals';
 import { Button, ButtonWithLoading } from '../common/Button';
 import { ExternalLink } from '../common/ExternalLink';
-import Modal from '../common/Modal';
-import Paragraph from '../common/Paragraph';
+import { Modal } from '../common/Modal';
+import { Paragraph } from '../common/Paragraph';
 import Text from '../common/Text';
 import View from '../common/View';
 

diff --git a/packages/desktop-client/src/components/modals/CreateEncryptionKey.tsx b/packages/desktop-client/src/components/modals/CreateEncryptionKey.tsx
@@ -12,8 +12,8 @@ import { ButtonWithLoading } from '../common/Button';
 import { ExternalLink } from '../common/ExternalLink';
 import { InitialFocus } from '../common/InitialFocus';
 import { Input } from '../common/Input';
-import Modal, { ModalButtons } from '../common/Modal';
-import Paragraph from '../common/Paragraph';
+import { Modal, ModalButtons } from '../common/Modal';
+import { Paragraph } from '../common/Paragraph';
 import Text from '../common/Text';
 import View from '../common/View';
 

diff --git a/packages/desktop-client/src/components/modals/CreateLocalAccount.tsx b/packages/desktop-client/src/components/modals/CreateLocalAccount.tsx
@@ -12,7 +12,7 @@ import { FormError } from '../common/FormError';
 import { InitialFocus } from '../common/InitialFocus';
 import { InlineField } from '../common/InlineField';
 import { Input } from '../common/Input';
-import Modal, { ModalButtons } from '../common/Modal';
+import { Modal, ModalButtons } from '../common/Modal';
 import Text from '../common/Text';
 import View from '../common/View';
 import { Checkbox } from '../forms';

diff --git a/packages/desktop-client/src/components/modals/EditField.jsx b/packages/desktop-client/src/components/modals/EditField.jsx
@@ -25,7 +25,7 @@ import PayeeAutocomplete, {
   PayeeItem,
 } from '../autocomplete/PayeeAutocomplete';
 import { Input } from '../common/Input';
-import Modal from '../common/Modal';
+import { Modal } from '../common/Modal';
 import View from '../common/View';
 import { SectionLabel } from '../forms';
 import DateSelect from '../select/DateSelect';

diff --git a/packages/desktop-client/src/components/modals/EditRule.jsx b/packages/desktop-client/src/components/modals/EditRule.jsx
@@ -31,9 +31,9 @@ import SubtractIcon from '../../icons/v0/Subtract';
 import InformationOutline from '../../icons/v1/InformationOutline';
 import { theme } from '../../style';
 import { Button } from '../common/Button';
-import Modal from '../common/Modal';
-import Select from '../common/Select';
-import Stack from '../common/Stack';
+import { Modal } from '../common/Modal';
+import { Select } from '../common/Select';
+import { Stack } from '../common/Stack';
 import Text from '../common/Text';
 import View from '../common/View';
 import { StatusBadge } from '../schedules/StatusBadge';

diff --git a/packages/desktop-client/src/components/modals/FixEncryptionKey.tsx b/packages/desktop-client/src/components/modals/FixEncryptionKey.tsx
@@ -11,8 +11,8 @@ import { Button, ButtonWithLoading } from '../common/Button';
 import { ExternalLink } from '../common/ExternalLink';
 import { InitialFocus } from '../common/InitialFocus';
 import { Input } from '../common/Input';
-import Modal, { ModalButtons } from '../common/Modal';
-import Paragraph from '../common/Paragraph';
+import { Modal, ModalButtons } from '../common/Modal';
+import { Paragraph } from '../common/Paragraph';
 import Text from '../common/Text';
 import View from '../common/View';
 

diff --git a/packages/desktop-client/src/components/modals/GoCardlessExternalMsg.tsx b/packages/desktop-client/src/components/modals/GoCardlessExternalMsg.tsx
@@ -19,8 +19,8 @@ import { Button } from '../common/Button';
 import { ExternalLink } from '../common/ExternalLink';
 import { LinkButton } from '../common/LinkButton';
 import { Menu } from '../common/Menu';
-import Modal from '../common/Modal';
-import Paragraph from '../common/Paragraph';
+import { Modal } from '../common/Modal';
+import { Paragraph } from '../common/Paragraph';
 import View from '../common/View';
 import { FormField, FormLabel } from '../forms';
 import { Tooltip } from '../tooltips';

diff --git a/packages/desktop-client/src/components/modals/GoCardlessInitialise.tsx b/packages/desktop-client/src/components/modals/GoCardlessInitialise.tsx
@@ -6,7 +6,7 @@ import { Error } from '../alerts';
 import { ButtonWithLoading } from '../common/Button';
 import { ExternalLink } from '../common/ExternalLink';
 import { Input } from '../common/Input';
-import Modal, { ModalButtons } from '../common/Modal';
+import { Modal, ModalButtons } from '../common/Modal';
 import type { ModalProps } from '../common/Modal';
 import Text from '../common/Text';
 import View from '../common/View';