Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

123 mrs resources not tested #142

Closed
wants to merge 5 commits into from
Closed

Conversation

dmicheneau
Copy link
Collaborator

@dmicheneau dmicheneau commented Jan 20, 2023

Description of your changes

feat(mrs/cluster): Add MRS Cluster example
chore(mrs/job): find an issue #140

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

NAME                                                        READY   SYNCED   EXTERNAL-NAME                          AGE
cluster.mrs.flexibleengine.upbound.io/example-mrs-cluster   False   True     30b44829-2aa6-4f31-95cb-0895737de1e7   20h

NAME                                                     READY   SYNCED   EXTERNAL-NAME                          AGE
vpcsubnet.vpc.flexibleengine.upbound.io/example-subnet   False   True     289c2821-cf2d-4796-859b-fa29d6f15a68   20h

NAME                                            READY   SYNCED   EXTERNAL-NAME                          AGE
vpc.vpc.flexibleengine.upbound.io/example-vpc   False   True     85b5b797-92d6-4749-9411-72298253be1b   20h

@dmicheneau dmicheneau linked an issue Jan 20, 2023 that may be closed by this pull request
1 task
@dmicheneau dmicheneau force-pushed the 123-mrs-resources-not-tested branch from 1080d8e to 482e1e2 Compare January 20, 2023 13:49
@github-actions
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "123 mrs resources not tested". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MRS] Resources not tested
1 participant