Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Futo Android keyboard #40

Closed
wants to merge 6 commits into from

Conversation

QADavidCalvo
Copy link
Contributor

@QADavidCalvo QADavidCalvo commented Jun 17, 2024

Add support for Futo Android keyboard

πŸ”οΈ Description

Added Futo to the available Android keyboards and the Xpaths needed to map the keys and suggestions.

🧐 Context

Only for Android devices (emulators and real devices)

⚠️ Side-effects / Shortcomings

none

βœ… How this was tested ?

To map the keys run kebbie show_layout -K futo
To evaluate the keyboard run kebbie evaluate -K futo

🌱 Checklist

  • Perform self-review of my own code
  • Comment the code, particularly in hard-to-understand areas
  • Update the documentation accordingly to the new code
  • Lint / format the code
  • Update existing tests / Add new tests
  • Tests are passing locally

@QADavidCalvo QADavidCalvo requested a review from astariul June 17, 2024 14:45
@QADavidCalvo QADavidCalvo self-assigned this Jun 17, 2024
@QADavidCalvo QADavidCalvo changed the title Android Futo keyboard support Add support for Futo Android keyboard Jun 17, 2024
@QADavidCalvo
Copy link
Contributor Author

Seems that the tests are not passing @astariul
I've launched them locally and they worked...

@astariul
Copy link
Collaborator

Tests are passing, it's just the coverage badge is not up-to-date.

You can update it locally with :

pytest
coverage-badge -o .github/badges/coverage.svg -f

And then push the changes.


Let's find a better way to deal with this coverage badge...

@astariul
Copy link
Collaborator

Looking good ! Thanks for re-organizing the dictionary πŸ˜…

We just have to update the documentation and we are good to go πŸ‘

@QADavidCalvo
Copy link
Contributor Author

I did it but no files were changed...
Done again and badge updated correctly.

@QADavidCalvo QADavidCalvo deleted the android-futo-keyboard-support branch June 18, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants