-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Swiftkey Android keyboard #25
Conversation
Lint is not passing because the Emulator constructor is too complex. I think it's okay to just put Line 428 in 642f0f7
Then you can fix the other issues with :
For the tests, they are all passing, but since you added some line of code, the coverage decreased from 78% to 77%. The job is failing because the coverage badge wasn't updated. You can update it with :
(I should really find a better way, if the badge could update automatically that would be great...) |
Fixed |
@QADavidCalvo I took the liberty to push code in your PR. Summary of my changes :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Feel free to merge this PR :)
On my side, I'll run the tests on swiftkey, and I'll upload the results in the leaderboard (in another PR)
Add support for Swiftkey Android keyboard
ποΈ Description
Added Swiftkey to the available Android keyboards and the Xpaths needed to map the keys and suggestions.
π§ Context
Only for Android devices (emulators and real devices)
β How this was tested ?
kebbie show_layout -K swiftkey
kebbie evaluate -K swiftkey
π± Checklist