Merge pull request #129 from Flagsmith/fix/null-flag-id

fix!: Remove flag ID properties/methods
Flagsmith · Dec 18, 2024 · 8d403c5 · 8d403c5
2 parents 97a6f89 + 4278dbb
commit 8d403c5
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/Flagsmith.FlagsmithClient/Flag.cs b/Flagsmith.FlagsmithClient/Flag.cs
@@ -15,8 +15,6 @@ public Flag(Feature feature, bool enabled, string value, int featureId = default
             this.Value = value;
             this.Feature = feature;
         }
-        [JsonProperty("id")]
-        public int Id { get; private set; }
         [JsonProperty("feature")]
         private Feature Feature { get; set; }
 
@@ -26,10 +24,6 @@ public Flag(Feature feature, bool enabled, string value, int featureId = default
         [JsonProperty("feature_state_value")]
         public string Value { get; private set; }
 
-        public int getFeatureId()
-        {
-            return this.Feature.Id;
-        }
         public string GetFeatureName()
         {
             return this.Feature.Name;

diff --git a/Flagsmith.FlagsmithClient/Flagsmith.FlagsmithClient.csproj b/Flagsmith.FlagsmithClient/Flagsmith.FlagsmithClient.csproj
@@ -7,7 +7,7 @@
     <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
     <PackageId>Flagsmith</PackageId>
     <Title>Flagsmith</Title>
-    <Version>6.0.0</Version>
+    <Version>7.0.0</Version>
     <Authors>flagsmith</Authors>
     <Company>Flagsmith</Company>
     <PackageDescription>Client SDK for Flagsmith. Ship features with confidence using feature flags and remote config. Host yourself or use our hosted version at https://flagsmith.com/</PackageDescription>

diff --git a/Flagsmith.FlagsmithClient/IFlag.cs b/Flagsmith.FlagsmithClient/IFlag.cs
@@ -2,11 +2,8 @@
 {
     public interface IFlag
     {
-        int Id { get; }
         bool Enabled { get; }
         string Value { get; }
-        int getFeatureId();
         string GetFeatureName();
-        string ToString();
     }
 }