[FB4] Proposal for fixing #7877 - disable an usage of SCALAR_ARRAY with BLOB datatype #7878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AY with BLOB datatype Additional change - the check of usage BY SCALAR_ARRAY with return parameter was moved from CreateAlterFunctionNode::executeAlter (execute stage) in CreateAlterFunctionNode::dsqlPass (prepare stage). Test with ISQL: DECLARE EXTERNAL FUNCTION UDF_DUMMY2_BSA__BLOB2 BLOB BY SCALAR_ARRAY RETURNS BLOB BY DESCRIPTOR ENTRY_POINT 'IB_UDF_abs' MODULE_NAME 'ib_udf'; Statement failed, SQLSTATE = 42000 CREATE FUNCTION UDF_DUMMY2_BSA__BLOB2 failed -SQL error code = -607 -Invalid command -BY SCALAR_ARRAY can't be used with BLOB datatype DECLARE EXTERNAL FUNCTION UDF_DUMMY2_BSA__BLOB3 integer BY SCALAR_ARRAY, BLOB BY SCALAR_ARRAY RETURNS PARAMETER 2 ENTRY_POINT 'IB_UDF_abs' MODULE_NAME 'ib_udf'; Statement failed, SQLSTATE = 42000 CREATE FUNCTION UDF_DUMMY2_BSA__BLOB3 failed -SQL error code = -607 -Invalid command -BY SCALAR_ARRAY can't be used as a return parameter
|
It seems to me this PR has the problem. I should check udfReturnPos in dsqlPass, too. |
The check of udfReturnPos was moved from CreateAlterFunctionNode::executeAlter in CreateAlterFunctionNode::dsqlPass Tests: DECLARE EXTERNAL FUNCTION UDF_DUMMY2_BSA__BLOB3 integer BY SCALAR_ARRAY, BLOB BY SCALAR_ARRAY RETURNS PARAMETER 0 ENTRY_POINT 'IB_UDF_abs' MODULE_NAME 'ib_udf'; Statement failed, SQLSTATE = 42000 Dynamic SQL Error -SQL error code = -842 -Positive value expected -At line 4, column 19 DECLARE EXTERNAL FUNCTION UDF_DUMMY2_BSA__BLOB3 integer BY SCALAR_ARRAY, BLOB BY SCALAR_ARRAY RETURNS PARAMETER 3 ENTRY_POINT 'IB_UDF_abs' MODULE_NAME 'ib_udf'; Statement failed, SQLSTATE = 38000 CREATE FUNCTION UDF_DUMMY2_BSA__BLOB3 failed -SQL error code = -607 -Invalid command -External function should have return position between 1 and 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional change - the check of usage BY SCALAR_ARRAY with return parameter was moved from CreateAlterFunctionNode::executeAlter (execute stage) in CreateAlterFunctionNode::dsqlPass (prepare stage).
Test with ISQL:
Note: new code uses the following operator:
firebird/src/common/classes/Nullable.h
Lines 73 to 76 in 255fc24