Set line-height & letter-spacing #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --mat-* css variables associated with line-height and letter-spacing styles are not correlated with the --fds-* css variables. This causes css classes which reference the --mat-* variables to be incorrect.
✅ Deploy Preview for lucid-bassi-bfa8cc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BeataKr
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --mat-* css variables associated with line-height and letter-spacing styles are not correlated with the --fds-* css variables. This causes css classes which reference the --mat-* variables to be incorrect.
Example of current values:
--mat-form-field-container-text-line-height:
1rem;--mat-form-field-container-text-size: 1rem;
--mat-form-field-container-text-tracking:
normal;--mat-form-field-subscript-text-line-height:
.75rem;--mat-form-field-subscript-text-size: .75rem;
--mat-form-field-subscript-text-tracking:
normal;Example of corrected values:
--mat-form-field-container-text-line-height:
1.5rem;--mat-form-field-container-text-size: 1rem;
--mat-form-field-container-text-tracking:
.5px;--mat-form-field-subscript-text-line-height:
1.125rem;--mat-form-field-subscript-text-size: .75rem;
--mat-form-field-subscript-text-tracking:
.4px;