Merge pull request #85 from Financial-Times/smoke-ignore-cert-errors

Ignore certificate errors

README.md

@@ -73,6 +73,8 @@ You can also run:
 
 This allows you to select a suite of URLs (in this case, "basic"), and open them in Chromium. This is useful for manually testing a set of URLs.
 
+If, when running locally, you are seeing errors about certificates not being valid, set NODE_ENV to be 'development' e.g. `NODE_ENV=development;n-test smoke -H http://localhost:8080`. This will use some launch options that ignore certificate errors.
+
 ### Expectations
 
 Checking response statii is great for checking that your application responds with _something_, but not necessarily the right thing. n-test comes with a bunch of basic things that you check for.

lib/smoke/smoke-test.js

@@ -65,7 +65,9 @@ class SmokeTest {
 		const puppetTests = [];
 		const crossBrowserTests = [];
 
-		this.browser = await puppeteer.launch();
+		// https://github.com/GoogleChrome/puppeteer/issues/2377
+		const launchOptions = (process.NODE_ENV === 'development') ? {args: ['--ignore-certificate-errors', '--enable-features=NetworkService']} : {};
+		this.browser = await puppeteer.launch(launchOptions);
 
 		for (let suiteOptions of configsToRun) {
 			for (let path in suiteOptions.urls) { //eslint-disable-line guard-for-in