-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/django 42 compatible #162
Feat/django 42 compatible #162
Conversation
…arang95/djangocms-navigation into feat/django-42-compatible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vipulnarang95,
This is a FIL specific package and not a DCA supported package so I can only offer a favour personally here.
The test failures look to be something django admin related. To debug this I would recommend adding breakpoints in the test and tracing the code through to the point of failure to see what is actually happening underneath.
Hi @Aiky30, Thankyou for the favor. Much appreciated.. I fixed major of them. Only one test is failing now.
|
Hi @vipulnarang95 , this test request does not response the html with your desired js file: navigation-tree-admin.js reference indeed. the change_list.html seems not using the correct template tag to load the template tag into the html. |
Hi @Aiky30 , Need your favor in this. The test which I mentioned above is failing as the treebeard template tag is not working as expected and the custom js is not find in the response. Would you be able to suggest something? |
@vipulnarang95 , I have fixed your errors, please check my PR : vipulnarang95#2 @Aiky30 , please also help to review my solution. |
…for django-treebeard > 4.6 in order to override js
Feat/django 42 compatible
https://github.com/divio/djangocms-text-ckeditor/tarball/master#egg=djangocms-text-ckeditor | ||
https://github.com/django-cms/djangocms-versioning/tarball/support/django-cms-4.0.x#egg=djangocms-versioning | ||
https://github.com/joshyu/djangocms-version-locking/tarball/feat/django-42-compatible#egg=djangocms-version-locking | ||
https://github.com/FidelityInternational/djangocms-moderation/tarball/feature/django-42-compat#egg=djangocms-moderation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace djangocms-moderation
to use https://github.com/django-cms/djangocms-moderation/tarball/master#egg=djangocms-moderation
Added Django support 4.2 and Python 3.10
Dropped support for django<3.2 and python<3.8