Added vault agent to k8s worker for testing purposes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienbonami
requested changes
Dec 20, 2024
| @@ -101,4 +101,35 @@ module "kubernetes_workers" { | |||
| } | |||
| } | |||
| } | |||
| vault_agent = { | |||
There was a problem hiding this comment.
The commit of submodule terraform-libvirt-kubernetes-node needs to be changed so this var is available.
| type = "approle" | ||
| config = { | ||
| role_id = "add_role_id" | ||
| secret_id = "add_secret_id" |
There was a problem hiding this comment.
I suggest to provide a complete example that works so therefore have valid values here.
| secret_id = "add_secret_id" | ||
| } | ||
| } | ||
| vault_address = "https://vault.ferlab.lan:" |
There was a problem hiding this comment.
There's a trailing : to remove at the end of the value.
| } | ||
| } | ||
| vault_address = "https://vault.ferlab.lan:" | ||
| vault_ca_cert = "" |
There was a problem hiding this comment.
The cert can be found in file ../shared/vault-ca.crt.
| ] | ||
| agent_config = "" | ||
| release_version = "1.17.2" | ||
| } |
There was a problem hiding this comment.
There's a variable extra_config that is missing here. Actually also in repo terraform-libvirt-kubernetes-node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.