Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider-deepl): support Arabic #409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhavesh-chaudhari
Copy link

@bhavesh-chaudhari bhavesh-chaudhari commented Aug 22, 2024

Description:

DeepL has added support for AR(Arabic) locale. I wanted to use this locale in my cms for localization but the translate plugin was throwing the error unsupported locale. This PR intends to add support for the same.

Source:
https://www.deepl.com/en/blog/deepl-welcomes-arabic
https://developers.deepl.com/docs/resources/supported-languages

@sargreal
Copy link
Member

Hi @bhavesh-chaudhari and thank you for your merge request!

I have one point, that is missing right now:

The different arabic variants for Uzbek (UZ-ARAB, UZ-ARAB-AF) and Punjabi (PA-ARAB, PA-ARAB-PK) are throwing errors in the tests. I believe these variant require extra care in the switch/case statement, similar to EN-GB or EN-US

@sargreal sargreal added the enhancement New feature or request label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants