Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port QGnomePlatform to LibAdwaita look #116

Closed
wants to merge 0 commits into from
Closed

Conversation

urFate
Copy link

@urFate urFate commented Oct 30, 2022

Port QGnomePlatform to LibAdwaita look.

Audacious

PolyMC

@urFate urFate marked this pull request as draft October 30, 2022 16:06
@urFate urFate marked this pull request as ready for review October 30, 2022 16:27
@grulja
Copy link
Collaborator

grulja commented Oct 31, 2022

Why did you remove shadows?

@urFate
Copy link
Author

urFate commented Oct 31, 2022

Why did you remove shadows?

I don't think shadows are suitable for a flat interface. There are also no shadows in Libadwaita applications (or they are so inconspicuous that they are not visible).

@grulja
Copy link
Collaborator

grulja commented Oct 31, 2022

clang-format check failed, I guess you will have to remove all your formatting changes. I will check this change later, I don't run GNOME on daily basis and I will need to properly check how libadwaita looks like compared to the current design.

@urFate
Copy link
Author

urFate commented Oct 31, 2022

clang-format check failed, I guess you will have to remove all your formatting changes. I will check this change later, I don't run GNOME on daily basis and I will need to properly check how libadwaita looks like compared to the current design.

Something weird happened with clang-format check. This warnings are just comments and code which i didn't touch.

image

@grulja
Copy link
Collaborator

grulja commented Oct 31, 2022

clang-format check failed, I guess you will have to remove all your formatting changes. I will check this change later, I don't run GNOME on daily basis and I will need to properly check how libadwaita looks like compared to the current design.

Something weird happened with clang-format check. This warnings are just comments and code which i didn't touch.

Yes, you did it here 3e7ced5. There are unrelated formatting changes.

@urFate
Copy link
Author

urFate commented Oct 31, 2022

@grulja clang-format check seems like broken. Another PR in this repo also failing this check anyway.

@grulja
Copy link
Collaborator

grulja commented Nov 1, 2022

@grulja clang-format check seems like broken. Another PR in this repo also failing this check anyway.

Should be fixed now, can you rebase?

@grulja
Copy link
Collaborator

grulja commented Nov 1, 2022

Please, do a rebase, not a merge. You now have a merge commit in your history. Also, there are still unrelated coding style changes to the header file.

@urFate
Copy link
Author

urFate commented Nov 1, 2022

Please, do a rebase, not a merge. You now have a merge commit in your history. Also, there are still unrelated coding style changes to the header file.

Sorry for this incident. It is fixable?

@grulja
Copy link
Collaborator

grulja commented Nov 1, 2022

You can squash some commits together and get rid of some changes using interactive rebase.

https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

You can then force push the changes.

@urFate
Copy link
Author

urFate commented Nov 4, 2022

@grulja Can you try run workflows?

@grulja
Copy link
Collaborator

grulja commented Dec 7, 2022

Hi, I'm not sure I will be able to review this anytime soon, I will be taking vacation soon until the next year. One thing I'm also considering is to start working #121 as this would simplify lot of things and we would automatically support basically all kind of GTK themes with one codebase. In such case I don't think this, even in case it gets merged, would get released as most likely the next release I will do for QGnomePlaform will be with libdecor support. Will see. In any case I really appreciate your contribution and I'm sorry if this was useless.

@urFate
Copy link
Author

urFate commented Dec 7, 2022

Hi, I'm not sure I will be able to review this anytime soon, I will be taking vacation soon until the next year. One thing I'm also considering is to start working #121 as this would simplify lot of things and we would automatically support basically all kind of GTK themes with one codebase. In such case I don't think this, even in case it gets merged, would get released as most likely the next release I will do for QGnomePlaform will be with libdecor support. Will see. In any case I really appreciate your contribution and I'm sorry if this was useless.

It's okay, I just wanted my desktop to be combined with QT applications with Wayland. The last thing I thought about contributing to the project was. It will be great if the QGnomePlatform gets customization :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants