Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] DTO Response Model 재정의 (일부) #36

Closed
wants to merge 1 commit into from
Closed

Conversation

eunki96
Copy link
Member

@eunki96 eunki96 commented May 25, 2023

📋 이슈 번호

🛠 구현 사항

  • List<> 예시 값 일부 작성, 확인 바람

📚 기타

@eunki96 eunki96 added the 📘 Documentation 명세나 markdown 파일 등 문서 요소 관련 label May 25, 2023
@eunki96 eunki96 self-assigned this May 25, 2023
@Juser0 Juser0 self-requested a review May 25, 2023 12:47
Copy link
Member

@Juser0 Juser0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어~
UserController하구 Jwt의 토큰에 이메일 / 식별자 / 역할 다 넣는거로 의도한거 맞지?
다시 확인하고 추가 커밋한담에 알려줘!

그러고 나서 merge할게!

@@ -264,7 +264,7 @@ public ResponseEntity<DefaultResponseDto<Object>> updatePassword(
@ApiResponses(value={
@ApiResponse(code = 200,
message = "REMINDERS_FOUND",
response = ReminderResponseDto.class),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리마인더 조회인데 UserResponseDto을 예시로 나타내는 게 맞아?
UserResponseDto는 모든 요소를 담고 있어서 예시로는 부적절해 보이는뎅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞네 저 부분 수정할게

@eunki96 eunki96 changed the title [Fix] DTO Response Model 재정의 (일부) = #33 [Fix] DTO Response Model 재정의 (일부) Jun 2, 2023
eunki96 added a commit that referenced this pull request Jun 7, 2023
@eunki96 eunki96 closed this Jul 1, 2023
@eunki96 eunki96 deleted the eunki96/#33 branch July 1, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📘 Documentation 명세나 markdown 파일 등 문서 요소 관련
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants