iOS autoPaginate ready for primetime #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds upon what @realaboo did, primarily solving the bug he pointed out where iOS fires multiple times on first load. Basically, I just fire a flag indicating whether the first load is complete and disable infinite scrolling until that point, and voila! Also, there is some minor fixes in `_renderPaginationView()`. First wasn't even going to show since it relied on `pagination === true` and not also the `autoPaginate' prop. In also guarantee standard `pagination` views aren't shown when `autoPaginate` is set. I supposed if you toggled both on, you might still have some issues, but it's not a big deal. It should be pretty obvious when those "issues" arise to toggle the one you're not using off. Lastly, I'd commit this into @realaboo's branch, but he did his work before various changes in the latest repo. So credit goes to him, but also know that this is already combined with the latest code. It should be good to go! Give it a whirl.
Closed
|
This is great! Also +1 for changing autoPagination to infiniteScrolling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon what @realaboo did in #10, primarily solving the bug he pointed out where iOS fires multiple times on first load. Basically, I just fire a flag indicating whether the first load is complete and disable infinite scrolling until that point, and voila!
Also, there is some minor fixes in
_renderPaginationView():pagination === trueand not also the `autoPaginate' prop. that's fixed.paginationviews won't shown whenautoPaginateis set. I supposed if you toggled both on, you might still have some issues, but it's not a big deal. It should be pretty obvious when those "issues" arise to toggle the one you're not using off.Lastly, I'd commit this into @realaboo's branch, but he did his work before various changes in the latest repo. So credit goes to him, but also know that this is already combined with the latest code. It should be good to go! Give it a whirl.