Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add licence choice + improve gridworld actions #2

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Add licence choice + improve gridworld actions #2

merged 2 commits into from
Sep 8, 2023

Conversation

kir0ul
Copy link
Contributor

@kir0ul kir0ul commented Sep 7, 2023

Description

Followup of #1 which adds the possibility of choosing the license and improves a bit the environment.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@kir0ul
feat: Add license to template
ac3730e
@kir0ul
refactor: misc
bd3f84f 
- Modif files tree in docs
- Improve main test
- Improve gridworld with enum for actions
pseudo-rnd-thoughts
pseudo-rnd-thoughts approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much closer are we have a completed tutorial?

@kir0ul
Copy link
Contributor Author

kir0ul commented Sep 8, 2023

How much closer are we have a completed tutorial?

Yes, sorry for the wait, here it is: Farama-Foundation/Gymnasium#709

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 59d5aed into Farama-Foundation:main Sep 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kir0ul @pseudo-rnd-thoughts