-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register PointMaze_Open_Diverse_GR #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodrigodelazcano do we want to add environments versions without a version bump?
}, | ||
kwargs, | ||
), | ||
max_episode_steps=300, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
300 time steps is the same as OPEN_DIVERSE_G
(which is good)
Also, would like to point out that, Gymnasium-Robotics/gymnasium_robotics/envs/maze/maps.py Lines 19 to 25 in f2754e1
|
@dtch1997 please run the |
Hi @Kallinteris-Andreas thanks for getting back to me on the PR. I believe the failing pre-commit check is unrelated to my changes. Looking at the stack trace, the pyright failures appear to be due to this file: I do not know how to fix these issues. Full stack trace from here:
|
@dtch1997 does it pass I am looking into the CI issues |
@Kallinteris-Andreas No, I have the same error when running the linters locally.
|
055be6a
into
Farama-Foundation:main
Description
Registers the
PointMaze_Open_Diverse_GR
environment.Fixes #194
Type of change
Please delete options that are not relevant.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)