Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Correct assertions in Maze environment reset #179

Merged

Conversation

rodrigodelazcano
Copy link
Member

Description

This PR fixes the comment in this previous PR #163 (comment)

The elements of "goal_cell" and "reset_cell" need to be inverted for the assertions since they represent the (i,j) cell in the maze map list of lists structure as specified in the docs.

The changes are made in both maze.py and maze_v4.py

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rodrigodelazcano rodrigodelazcano merged commit a966c67 into Farama-Foundation:main Sep 16, 2023
5 checks passed
@rodrigodelazcano rodrigodelazcano deleted the fix-goal-assertion branch September 16, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant