Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ› FIX. cors ์˜ค๋ฅ˜ ์ˆ˜์ • #13

Merged
merged 3 commits into from
May 2, 2024
Merged

๐Ÿ› FIX. cors ์˜ค๋ฅ˜ ์ˆ˜์ • #13

merged 3 commits into from
May 2, 2024

Conversation

junhaa
Copy link
Collaborator

@junhaa junhaa commented May 2, 2024 

- commit message๊ฐ€ ์ ์ ˆํ•œ์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.
- ๋งˆ์ง€๋ง‰์œผ๋กœ Coding Convention์„ ์ค€์ˆ˜ํ–ˆ๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.
- ์ ์ ˆํ•œ branch๋กœ ์š”์ฒญํ–ˆ๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.
- Assignees, Label์„ ๋ถ™์—ฌ์ฃผ์„ธ์š”.
- ๊ฐ€๋Šฅํ•œ ์ด์Šˆ๋ฅผ Link ํ•ด์ฃผ์„ธ์š”.
- PR์ด ์Šน์ธ๋œ ๊ฒฝ์šฐ ํ•ด๋‹น ๋ธŒ๋žœ์น˜๋Š” ์‚ญ์ œ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

๊ด€๋ จ ์ด์Šˆ

closed #

๋ณ€๊ฒฝ ์‚ฌํ•ญ ๋ฐ ์ด์œ 

ํ•ด๋‹น pr์—์„œ ์ž‘์—…ํ•œ ๋‚ด์—ญ์„ ์ ์–ด์ฃผ์„ธ์š”.

PR Point

๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ ์ฃผ์˜ ์‚ฌํ•ญ (๋ชจ๋“ˆ ์„ค์น˜ ๋“ฑ)์„ ์ ์–ด์ฃผ์„ธ์š”.

๐Ÿ“ธ ScreenShot

@junhaa junhaa self-assigned this May 2, 2024
@junhaa junhaa added the ๐Ÿ› bug Something isn't working label May 2, 2024
@junhaa junhaa merged commit 3f9a7d7 into dev May 2, 2024
1 check passed
@junhaa junhaa deleted the fix/#12-cors branch May 2, 2024 05:52
@junhaa junhaa restored the fix/#12-cors branch May 2, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@junhaa junhaa

Labels
๐Ÿ› bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@junhaa