Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/goldilocks] Add pod priority class for goldilocks #1543

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

harshbhardwaj5
Copy link

@harshbhardwaj5 harshbhardwaj5 commented Oct 30, 2024

Why This PR?
a short description of why this PR is needed
There is no pod priority class support available for goldilocks start so this change add pod priority class in goldilocks deployment
Fixes #1544

Changes
Changes proposed in this pull request:

  • The addition of a pod priority class allows users to specify their own values based on their requirements, as there are no hardcoded defaults.

Checklist:

  • I have included the name of the chart in the title of this PR in square brackets i.e. [stable/goldilocks].
  • I have updated the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • Any new values have been added to the README for the Chart, or helm-docs --sort-values-order=file has been run for the charts that support it.

@harshbhardwaj5 harshbhardwaj5 marked this pull request as draft October 30, 2024 14:00
@harshbhardwaj5 harshbhardwaj5 marked this pull request as ready for review October 30, 2024 14:06
@harshbhardwaj5
Copy link
Author

harshbhardwaj5 commented Nov 5, 2024

@sudermanjr can this be reviewed

@harshbhardwaj5
Copy link
Author

harshbhardwaj5 commented Nov 5, 2024

@vitorvezani can this be reviewed

@harshbhardwaj5
Copy link
Author

@sudermanjr can you please approve

@vitorvezani
Copy link
Member

vitorvezani commented Nov 11, 2024

Hi @harshbhardwaj5 -- thanks for the contribution, added a couple of suggestions to keep consistent with other configuration

@harshbhardwaj5
Copy link
Author

Hi @harshbhardwaj5 -- thanks for the contribution, added a couple of suggestions to keep consistent with other configuration

Hi thanks for suggestions, fixed it
Kindly approve @vitorvezani

@harshbhardwaj5
Copy link
Author

I think @sudermanjr review is mandatory for it to merge

@harshbhardwaj5
Copy link
Author

@sudermanjr Hi can we get a approval here

@harshbhardwaj5
Copy link
Author

Hi @sudermanjr , Can we get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No PodPriorityClass for Goldilocks Deployment
2 participants