Skip to content

Bump embedded-hal to rc.2 #101

Bump embedded-hal to rc.2

Bump embedded-hal to rc.2 #101

GitHub Actions / clippy succeeded Dec 4, 2023 in 0s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.72.0-nightly (5ea666864 2023-06-27)
  • cargo 1.72.0-nightly (03bc66b55 2023-06-23)
  • clippy 0.1.72 (5ea6668 2023-06-27)

Annotations

Check warning on line 131 in ublox-cellular/src/registration.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `act` is never read

warning: field `act` is never read
   --> ublox-cellular/src/registration.rs:131:5
    |
128 | pub struct RegistrationParams {
    |            ------------------ field in this struct
...
131 |     act: RatAct,
    |     ^^^
    |
    = note: `RegistrationParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

Check warning on line 38 in ublox-cellular/src/registration.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods `started` and `updated` are never used

warning: methods `started` and `updated` are never used
  --> ublox-cellular/src/registration.rs:38:12
   |
23 | impl CellularRegistrationStatus {
   | ------------------------------- methods in this implementation
...
38 |     pub fn started(&self) -> Option<Instant> {
   |            ^^^^^^^
...
42 |     pub fn updated(&self) -> Option<Instant> {
   |            ^^^^^^^

Check warning on line 41 in ublox-cellular/src/module_timing.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `kill_time` is never used

warning: function `kill_time` is never used
  --> ublox-cellular/src/module_timing.rs:41:8
   |
41 | pub fn kill_time() -> Option<Duration> {
   |        ^^^^^^^^^

Check warning on line 67 in ublox-cellular/src/client.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `urc_channel` is never read

warning: field `urc_channel` is never read
  --> ublox-cellular/src/client.rs:67:5
   |
64 | pub struct Device<'buf, 'sub, AtCl, AtUrcCh, Config, const N: usize, const L: usize> {
   |            ------ field in this struct
...
67 |     urc_channel: &'buf AtUrcCh,
   |     ^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 404 in ublox-cellular/src/services/data/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `profile_id`

warning: unused variable: `profile_id`
   --> ublox-cellular/src/services/data/mod.rs:404:52
    |
404 |     fn activate_context(&mut self, cid: ContextId, profile_id: ProfileId) -> nb::Result<(), Error> {
    |                                                    ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_profile_id`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 52 in ublox-cellular/src/services/data/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `heapless::String`

warning: unused import: `heapless::String`
  --> ublox-cellular/src/services/data/mod.rs:52:5
   |
52 | use heapless::String;
   |     ^^^^^^^^^^^^^^^^

Check warning on line 48 in ublox-cellular/src/services/data/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `GetPacketSwitchedNetworkData`, `SetPacketSwitchedAction`, `SetPacketSwitchedConfig`

warning: unused imports: `GetPacketSwitchedNetworkData`, `SetPacketSwitchedAction`, `SetPacketSwitchedConfig`
  --> ublox-cellular/src/services/data/mod.rs:48:5
   |
48 |     GetPacketSwitchedNetworkData, SetPacketSwitchedAction, SetPacketSwitchedConfig,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 45 in ublox-cellular/src/services/data/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `PacketSwitchedAction`, `PacketSwitchedNetworkDataParam`, `PacketSwitchedParam`, `ProtocolType`

warning: unused imports: `PacketSwitchedAction`, `PacketSwitchedNetworkDataParam`, `PacketSwitchedParam`, `ProtocolType`
  --> ublox-cellular/src/services/data/mod.rs:45:5
   |
45 |     PacketSwitchedAction, PacketSwitchedNetworkDataParam, PacketSwitchedParam, ProtocolType,
   |     ^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^

Check warning on line 43 in ublox-cellular/src/services/data/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `crate::command::psn::responses::PacketSwitchedNetworkData`

warning: unused import: `crate::command::psn::responses::PacketSwitchedNetworkData`
  --> ublox-cellular/src/services/data/mod.rs:43:5
   |
43 | use crate::command::psn::responses::PacketSwitchedNetworkData;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Check warning on line 420 in ublox-cellular/src/client.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded sub `cfg` when there is only one condition

warning: unneeded sub `cfg` when there is only one condition
   --> ublox-cellular/src/client.rs:420:15
    |
420 |         #[cfg(any(feature = "toby-r2"))]
    |               ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "toby-r2"`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg

Check warning on line 235 in ublox-cellular/src/client.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded sub `cfg` when there is only one condition

warning: unneeded sub `cfg` when there is only one condition
   --> ublox-cellular/src/client.rs:235:15
    |
235 |         #[cfg(any(feature = "lara-r6"))]
    |               ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "lara-r6"`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
    = note: `#[warn(clippy::non_minimal_cfg)]` on by default