Skip to content

Bump embedded-hal to rc.2 #101

Bump embedded-hal to rc.2

Bump embedded-hal to rc.2 #101

Triggered via pull request December 4, 2023 11:50
Status Success
Total duration 1m 1s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

13 warnings
field `act` is never read: ublox-cellular/src/registration.rs#L131
warning: field `act` is never read --> ublox-cellular/src/registration.rs:131:5 | 128 | pub struct RegistrationParams { | ------------------ field in this struct ... 131 | act: RatAct, | ^^^ | = note: `RegistrationParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
methods `started` and `updated` are never used: ublox-cellular/src/registration.rs#L38
warning: methods `started` and `updated` are never used --> ublox-cellular/src/registration.rs:38:12 | 23 | impl CellularRegistrationStatus { | ------------------------------- methods in this implementation ... 38 | pub fn started(&self) -> Option<Instant> { | ^^^^^^^ ... 42 | pub fn updated(&self) -> Option<Instant> { | ^^^^^^^
function `kill_time` is never used: ublox-cellular/src/module_timing.rs#L41
warning: function `kill_time` is never used --> ublox-cellular/src/module_timing.rs:41:8 | 41 | pub fn kill_time() -> Option<Duration> { | ^^^^^^^^^
field `urc_channel` is never read: ublox-cellular/src/client.rs#L67
warning: field `urc_channel` is never read --> ublox-cellular/src/client.rs:67:5 | 64 | pub struct Device<'buf, 'sub, AtCl, AtUrcCh, Config, const N: usize, const L: usize> { | ------ field in this struct ... 67 | urc_channel: &'buf AtUrcCh, | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
unused variable: `profile_id`: ublox-cellular/src/services/data/mod.rs#L404
warning: unused variable: `profile_id` --> ublox-cellular/src/services/data/mod.rs:404:52 | 404 | fn activate_context(&mut self, cid: ContextId, profile_id: ProfileId) -> nb::Result<(), Error> { | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_profile_id` | = note: `#[warn(unused_variables)]` on by default
unused import: `heapless::String`: ublox-cellular/src/services/data/mod.rs#L52
warning: unused import: `heapless::String` --> ublox-cellular/src/services/data/mod.rs:52:5 | 52 | use heapless::String; | ^^^^^^^^^^^^^^^^
unused imports: `GetPacketSwitchedNetworkData`, `SetPacketSwitchedAction`, `SetPacketSwitchedConfig`: ublox-cellular/src/services/data/mod.rs#L48
warning: unused imports: `GetPacketSwitchedNetworkData`, `SetPacketSwitchedAction`, `SetPacketSwitchedConfig` --> ublox-cellular/src/services/data/mod.rs:48:5 | 48 | GetPacketSwitchedNetworkData, SetPacketSwitchedAction, SetPacketSwitchedConfig, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^
unused imports: `PacketSwitchedAction`, `PacketSwitchedNetworkDataParam`, `PacketSwitchedParam`, `ProtocolType`: ublox-cellular/src/services/data/mod.rs#L45
warning: unused imports: `PacketSwitchedAction`, `PacketSwitchedNetworkDataParam`, `PacketSwitchedParam`, `ProtocolType` --> ublox-cellular/src/services/data/mod.rs:45:5 | 45 | PacketSwitchedAction, PacketSwitchedNetworkDataParam, PacketSwitchedParam, ProtocolType, | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^
unused import: `crate::command::psn::responses::PacketSwitchedNetworkData`: ublox-cellular/src/services/data/mod.rs#L43
warning: unused import: `crate::command::psn::responses::PacketSwitchedNetworkData` --> ublox-cellular/src/services/data/mod.rs:43:5 | 43 | use crate::command::psn::responses::PacketSwitchedNetworkData; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unneeded sub `cfg` when there is only one condition: ublox-cellular/src/client.rs#L420
warning: unneeded sub `cfg` when there is only one condition --> ublox-cellular/src/client.rs:420:15 | 420 | #[cfg(any(feature = "toby-r2"))] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "toby-r2"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
unneeded sub `cfg` when there is only one condition: ublox-cellular/src/client.rs#L235
warning: unneeded sub `cfg` when there is only one condition --> ublox-cellular/src/client.rs:235:15 | 235 | #[cfg(any(feature = "lara-r6"))] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "lara-r6"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg = note: `#[warn(clippy::non_minimal_cfg)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build & Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/